May 2, 2025 · Apr 11, 2025 · Apr 11, 2025
diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py
        actual = self.get_suggestion(instance.foo)
        self.assertNotIn("self.blech", actual)

    def test_unbound_local_error_with_side_effect(self):
        # gh-132385
        class A:
            def __getattr__(self, key):
                if key == 'foo':
                    raise AttributeError('foo')
                if key == 'spam':
                    raise ValueError('spam')

            def bar(self):
                foo
            def baz(self):
                spam

        suggestion = self.get_suggestion(A().bar)
        self.assertNotIn('self.', suggestion)
        self.assertIn("'foo'", suggestion)

        suggestion = self.get_suggestion(A().baz)
        self.assertNotIn('self.', suggestion)
        self.assertIn("'spam'", suggestion)

    def test_unbound_local_error_does_not_match(self):
        def func():
            something = 3
diff --git a/Lib/traceback.py b/Lib/traceback.py
        # has the wrong name as attribute
        if 'self' in frame.f_locals:
            self = frame.f_locals['self']
            if hasattr(self, wrong_name):
            try:
                has_wrong_name = hasattr(self, wrong_name)
            except Exception:
                has_wrong_name = False
            if has_wrong_name:
                return f"self.{wrong_name}"

    try:
diff --git a/Misc/NEWS.d/next/Library/2025-04-11-12-41-47.gh-issue-132385.86HoA7.rst b/Misc/NEWS.d/next/Library/2025-04-11-12-41-47.gh-issue-132385.86HoA7.rst
 Fix instance error suggestions trigger potential exceptions
 in :meth:`object.__getattr__` in :mod:`traceback`.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4504,6 +4504,28 @@ def foo(self):
		actual = self.get_suggestion(instance.foo)
		self.assertNotIn("self.blech", actual)

		def test_unbound_local_error_with_side_effect(self):
		# gh-132385
		class A:
		def __getattr__(self, key):
		if key == 'foo':
		raise AttributeError('foo')
		if key == 'spam':
		raise ValueError('spam')

		def bar(self):
		foo
		def baz(self):
		spam

		suggestion = self.get_suggestion(A().bar)
		self.assertNotIn('self.', suggestion)
		self.assertIn("'foo'", suggestion)

		suggestion = self.get_suggestion(A().baz)
		self.assertNotIn('self.', suggestion)
		self.assertIn("'spam'", suggestion)

		def test_unbound_local_error_does_not_match(self):
		def func():
		something = 3
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1532,7 +1532,11 @@ def _compute_suggestion_error(exc_value, tb, wrong_name):
		# has the wrong name as attribute
		if 'self' in frame.f_locals:
		self = frame.f_locals['self']
		if hasattr(self, wrong_name):
		try:
		has_wrong_name = hasattr(self, wrong_name)
		except Exception:
iritkatriel marked this conversation as resolved. Show resolvedHide resolved
		has_wrong_name = False
		if has_wrong_name:
		return f"self.{wrong_name}"

		try:
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fix instance error suggestions trigger potential exceptions
		in :meth:`object.__getattr__` in :mod:`traceback`.