Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-91153: Fix bytearray holding a reference to its internal buffer when calling into potentially mutating __index__ methods#132379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bast0006 wants to merge5 commits intopython:mainChoose a base branch frombast0006:bast0006/gh-91153
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+48 −2
Open
Changes from1 commit
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
71ae212
GH-91153: Handle _getbytevalue potentially invalidating bytearray all…
bast0006b2f7df5
GH-91153: Add additional cases to `test_mutating_index`
bast0006bb96c2a
GH-91153: Move mutating index bytearray test to it's own separate test
bast0006d29422b
GH-91153: add news entry
bast0006d3d1974
Nit cleanup
bast0006File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
GH-91153: Handle _getbytevalue potentially invalidating bytearray all…
…ocation during item assignment
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit71ae2125197bcc791c7d6e7b45c097dd4bd81618
There are no files selected for viewing
7 changes: 5 additions & 2 deletionsObjects/bytearrayobject.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.