NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-126703: Fix possible use after free in pycfunction freelist#132319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Fidget-Spinner merged 4 commits intopython:mainfromFidget-Spinner:freelist-fix

Apr 9, 2025

Merged

gh-126703: Fix possible use after free in pycfunction freelist#132319

Fidget-Spinner merged 4 commits intopython:mainfromFidget-Spinner:freelist-fix

Apr 9, 2025

Conversation

Copy link

Member

Fidget-Spinner commentedApr 9, 2025•
edited by bedevere-appbot
Loading

Issue:Use freelist for range object, iterator objects and other often used objects #126703

Fix possible use after free in pycfunction freelist

c68d4f1

bedevere-appbot added the awaiting core review label

Apr 9, 2025

Fidget-Spinner requested a review fromeendebakpt

April 9, 2025 13:45

Fidget-Spinner changed the title~~gh-128692: Fix possible use after free in pycfunction freelist~~gh-126703: Fix possible use after free in pycfunction freelist

Apr 9, 2025

Copy link

MemberAuthor

Fidget-Spinner commentedApr 9, 2025

@hawkinsp does this look right to you?

📜🤖 Added by blurb_it.

4fa1daf

hawkinsp reviewed

Apr 9, 2025

View reviewed changes

Objects/methodobject.c Outdated

		@@ -173,12 +173,16 @@ meth_dealloc(PyObject *self)
		if (m->m_weakreflist != NULL) {
		PyObject_ClearWeakRefs((PyObject*) m);
		}
		// We need to access ml_flags here rather than later.
		// `m` might have the same lifetime