Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-131507: Add a way to recreate theMisc/mypy
symlinks if missing#132274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
They will be removed in source tarballs so they don't appearin the SBOM.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
(I undid the mistaken force-push, but there's no log entry about that happening.) |
16dcb57
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ssing (pythonGH-132274)They will be removed in source tarballs so they don't appearin the SBOM.(cherry picked from commit16dcb57)Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
GH-132293 is a backport of this pull request to the3.13 branch. |
…ssing (python#132274)They will be removed in source tarballs so they don't appearin the SBOM.Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
They will be removed in source tarballs so they don't appear in the SBOM.
This is an alternative to#132270 that keeps the symlinks in the repository. This has the following advantages:
.gitignore
file;mypy.ini
configuration files that add theMisc/mypy
directory can be used in a local type-checking workflow without running any additional tools.This allows running type checking without building Python first or running the additional script manually. This is important because the type-checking errors emitted due to missing symlinks are confusing and don't suggest what the solution is.
The only disadvantage of this PR compared to#132270 is that we still keep symlinks in the repository 🤷🏻♂️