Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-131507: Add a way to recreate theMisc/mypy symlinks if missing#132274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 2 commits intopython:mainfromambv:keep-symlinks-in-repo
Apr 8, 2025

Conversation

ambv
Copy link
Contributor

@ambvambv commentedApr 8, 2025
edited by bedevere-appbot
Loading

They will be removed in source tarballs so they don't appear in the SBOM.

This is an alternative to#132270 that keeps the symlinks in the repository. This has the following advantages:

  • the list of the modules isn't stored in a.gitignore file;
  • anymypy.ini configuration files that add theMisc/mypy directory can be used in a local type-checking workflow without running any additional tools.

This allows running type checking without building Python first or running the additional script manually. This is important because the type-checking errors emitted due to missing symlinks are confusing and don't suggest what the solution is.

The only disadvantage of this PR compared to#132270 is that we still keep symlinks in the repository 🤷🏻‍♂️

They will be removed in source tarballs so they don't appearin the SBOM.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@ambvambvforce-pushed thekeep-symlinks-in-repo branch frome82534d to987b04aCompareApril 8, 2025 17:31
@ambv
Copy link
ContributorAuthor

ambv commentedApr 8, 2025

(I undid the mistaken force-push, but there's no log entry about that happening.)

@ambvambv merged commit16dcb57 intopython:mainApr 8, 2025
94 checks passed
@miss-islington-app
Copy link

Thanks@ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 8, 2025
…ssing (pythonGH-132274)They will be removed in source tarballs so they don't appearin the SBOM.(cherry picked from commit16dcb57)Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

GH-132293 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 8, 2025
ambv added a commit that referenced this pull requestApr 8, 2025
…issing (GH-132274) (#132293)They will be removed in source tarballs so they don't appear in the SBOM.(cherry picked from commit16dcb57)Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…ssing (python#132274)They will be removed in source tarballs so they don't appearin the SBOM.Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@ambvambv deleted the keep-symlinks-in-repo branchMay 5, 2025 21:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@pablogsalpablogsalpablogsal approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ambv@pablogsal@StanFromIreland

[8]ページ先頭

©2009-2025 Movatter.jp