Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-131507: Remove Misc/mypy symlinks from the repository#132270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
They would end up in source tarballs and consequently in the SBOM. We don'twant that.
| @@ -0,0 +1,5 @@ | |||
| # This list is also used in make_symlinks.py, only put actual concrete paths below | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's a pity .gitignore doesn't let you include other files.
| would have to be part of the SBOM, which we don't want either. | ||
| Instead, this directory ships with a `make_symlinks.py` script, which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FWIW, I would be inclined to not symlink anything, and instead copy files to a separate directory to run mypy on... but then I don't use mypy and I have no idea how that would integrate with normal edit-typecheck workflows people have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
copying files makes it annoying for a local workflow since then you have to copy the tree for every mypy run. that's too slow.
I'm going with#132274 instead. |
Uh oh!
There was an error while loading.Please reload this page.
They would end up in source tarballs and consequently in the SBOM. We don't want that.