Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-87790: support thousands separators for formatting fractional part of Fraction#132204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromskirpichev:frac-sep-Fraction/87790
Jul 7, 2025

Conversation

@skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedApr 7, 2025•
edited by bedevere-appbot
Loading

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Test also errors for'.f' and'.6_f'.

@skirpichev
Copy link
ContributorAuthor

Test also errors for '.f' and '.6_f'.

I suspect you are about._6f. This test was added intest_invalid_formats(). Missing precision already was tested.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

@hugovkhugovk changed the titlegh-87790: support thousands separators for formatting fractional part of Fraction'sgh-87790: support thousands separators for formatting fractional part of FractionJul 7, 2025
@hugovkhugovk merged commit3e849d7 intopython:mainJul 7, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks@skirpichev for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@skirpichev and@hugovk, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 3e849d75f400569cbf3c29c356061c788284b71e 3.14

@skirpichevskirpichev deleted the frac-sep-Fraction/87790 branchJuly 7, 2025 08:58
@skirpichevskirpichev added needs backport to 3.14bugs and security fixes and removed needs backport to 3.14bugs and security fixes labelsJul 7, 2025
@miss-islington-app
Copy link

Thanks@skirpichev for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@skirpichev and@hugovk, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 3e849d75f400569cbf3c29c356061c788284b71e 3.14

@serhiy-storchakaserhiy-storchaka added needs backport to 3.14bugs and security fixes and removed needs backport to 3.14bugs and security fixes labelsJul 7, 2025
@miss-islington-app
Copy link

Thanks@skirpichev for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 7, 2025
…l part of Fraction (pythonGH-132204)(cherry picked from commit3e849d7)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

GH-136364 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJul 7, 2025
hugovk pushed a commit that referenced this pull requestJul 7, 2025
…al part of Fraction (GH-132204) (#136364)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull requestJul 11, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull requestJul 12, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull requestJul 13, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull requestAug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull requestAug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@picnixzpicnixzAwaiting requested review from picnixz

@hugovkhugovkAwaiting requested review from hugovk

Assignees

@hugovkhugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev@serhiy-storchaka@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp