Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-122040: RewordModules/xxmodule.c module-level comment#132201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 2 commits intopython:mainfromsonnyding1:xxmodule-comment
Apr 7, 2025

Conversation

@sonnyding1
Copy link
Contributor

@sonnyding1sonnyding1 commentedApr 7, 2025
edited by bedevere-appbot
Loading

Fixes#122040. As per the discussion in the issue, I have modified some comments that might cause confusion.

@python-cla-bot
Copy link

python-cla-botbot commentedApr 7, 2025
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@picnixzpicnixz added skip news needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsApr 7, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixzpicnixzenabled auto-merge (squash)April 7, 2025 07:45
@picnixz
Copy link
Member

Thank you for the fix!

sonnyding1 reacted with laugh emoji

@picnixzpicnixzdisabled auto-mergeApril 7, 2025 07:46
@picnixzpicnixzenabled auto-merge (squash)April 7, 2025 07:47
@picnixzpicnixz changed the titlegh-122040: Fix xxmodule.c comment on headergh-122040: RewordModules/xxmodule.c module-level commentApr 7, 2025
@picnixzpicnixz merged commitaf8d1b9 intopython:mainApr 7, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks@sonnyding1 for the PR, and@picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 7, 2025
…thonGH-132201)(cherry picked from commitaf8d1b9)Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 7, 2025
…thonGH-132201)(cherry picked from commitaf8d1b9)Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
@bedevere-app
Copy link

GH-132207 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 7, 2025
@bedevere-app
Copy link

GH-132208 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelApr 7, 2025
picnixz pushed a commit that referenced this pull requestApr 7, 2025
…H-132201) (#132208)gh-122040: reword `Modules/xxmodule.c` module-level comment (GH-132201)(cherry picked from commitaf8d1b9)Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
picnixz pushed a commit that referenced this pull requestApr 7, 2025
…H-132201) (#132207)gh-122040: reword `Modules/xxmodule.c` module-level comment (GH-132201)(cherry picked from commitaf8d1b9)Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable Refleaks 3.13 (tier-2) has failed when building commit71b5375.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1512/builds/484) and take a look at the build logs.
  4. Check if the failure is related to this commit (71b5375) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1512/builds/484

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line356, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertIn(f"py::foo:{script}", stdout)~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'py::foo:/tmp/test_python_4l2tugj7/tmpeoyng3v9/perftest.py' not found in 'python 2102378 1187857.397505:          1 cycles:Pu: \n\t    ffff89068ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2102378 1187857.397532:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff89068ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2102378 1187857.398077:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff88e5e300 __pthread_tunables_init+0x0 (/usr/lib64/libc.so.6)\n\t    ffff88f18dcb __libc_early_init+0xcb (/usr/lib64/libc.so.6)\n\t    ffff89066523 dl_main+0x1723 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff890635ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89064b17 _dl_start_final+0x5ab (inlined)\n\t    ffff89064b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89068ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2102378 1187857.398101:        346 cycles:Pu: \n\t    ffff88e5e304 __pthread_tunables_init+0x4 (/usr/lib64/libc.so.6)\n\t    ffff88f18dcb __libc_early_init+0xcb (/usr/lib64/libc.so.6)\n\t    ffff89066523 dl_main+0x1723 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff890635ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89064b17 _dl_start_final+0x5ab (inlined)\n\t    ffff89064b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89068ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2102378 1187857.399093:       1104 cycles:Pu: \n\t          50bba8 _PyMem_DebugRawAlloc+0x0 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          50bcb7 _PyMem_DebugRawMalloc+0x17 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          52230f PyMem_RawMalloc+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          62f30f _Py_hashtable_set+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          55cf2b intern_static+0x83 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5764fb _PyUnicode_InternStatic+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          576daf _PyUnicode_InitStaticStrings+0x857 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e377 init_global_interned_strings+0x77 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e5bf _PyUnicode_InitGlobalObjects+0x63 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65315f pycore_init_global_objects+0x23 (/hom@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2102378 1187857.399139:      52469 cycles:Pu: \n\t          55bb20 unicode_hash+0x18 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          55bbe3 hashtable_unicode_hash+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          62ef7f _Py_hashtable_get_entry_generic+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          62f2ff _Py_hashtable_set+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          55cf2b intern_static+0x83 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5764fb _PyUnicode_InternStatic+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          577acf _PyUnicode_InitStaticStrings+0x1577 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e377 init_global_interned_strings+0x77 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e5bf _PyUnicode_InitGlobalObjects+0x63 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65315f pycore_init_global_objects+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653707 pycore_interp_init+0x2b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6539e3 pyinit_config+0xaf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b05b pyinit_core+0xdb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b133 Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b2ef pymain_init+0xff (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b3b3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b447 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41ddb7 main+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff88df625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff88df633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2102378 1187857.400150:     112691 cycles:Pu: \n\t          4ecaf4 dictkeys_get_index+0x14 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4ecc17 do_lookup+0xbb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4eccb3 unicodekeys_lookup_unicode+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f1fbb _Py_dict_lookup+0x3b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f547b dict_setdefault_ref_lock_held+0x22b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f570b PyDict_SetDefaultRef+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          53a1d7 type_add_method+0x63 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          53a31f type_add_methods+0x2b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          53a887 type_ready_fill_dict+0x1f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5476d3 type_ready+0x93 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aaTraceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line356, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertIn(f"py::foo:{script}", stdout)~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'py::foo:/tmp/test_python_mzxw497j/tmpuj2doz_0/perftest.py' not found in 'python 1979064 1186821.852684:          1 cycles:Pu: \n\t    ffff93cc1ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1979064 1186821.852707:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff93cc1ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1979064 1186821.853071:          1 cycles:Pu: \n\t    ffff93cad058 _dl_map_segments+0x378 (inlined)\n\t    ffff93cad058 _dl_map_object_from_fd+0x378 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93cae133 _dl_map_object+0x1e7 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93ca95bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93ca8303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93ca9b33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93cbf19f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93cbc5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93cbdb17 _dl_start_final+0x5ab (inlined)\n\t    ffff93cbdb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93cc1ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1979064 1186821.853108:        352 cycles:Pu: \n\tffffaa282d37f654 [unknown] ([unknown])\n\tffffaa282d380484 [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff93cc4c9c __memset_generic+0x9c (inlined)\n\t    ffff93cad0db _dl_map_segments+0x3fb (inlined)\n\t    ffff93cad0db _dl_map_object_from_fd+0x3fb (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93cae133 _dl_map_object+0x1e7 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93ca95bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93ca8303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff93ca9b33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarc

@sonnyding1sonnyding1 deleted the xxmodule-comment branchApril 8, 2025 01:58
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading comment inModules/xxmodule.c

3 participants

@sonnyding1@picnixz@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp