Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-84481: Make ZipFile.data_offset more robust#132178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
picnixz approved these changesApr 8, 2025
6cd1d6c intopython:main 42 checks passed
Uh oh!
There was an error while loading.Please reload this page.
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
emmatyping added a commit to emmatyping/cpython that referenced this pull requestJul 21, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 21, 2025
* Revert "pythongh-84481: Make ZipFile.data_offset more robust (pythonGH-132178)"This reverts commit6cd1d6c.* Revert "pythongh-84481: Add ZipFile.data_offset attribute (pythonGH-132165)"This reverts commit0788948.---------(cherry picked from commit6bf1c0a)Co-authored-by: Emma Smith <emma@emmatyping.dev>Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this pull requestJul 22, 2025
…36955)gh-136170: Revert adding `ZipFile.data_offset` (GH-136950)* Revert "gh-84481: Make ZipFile.data_offset more robust (GH-132178)"This reverts commit6cd1d6c.* Revert "gh-84481: Add ZipFile.data_offset attribute (GH-132165)"This reverts commit0788948.---------(cherry picked from commit6bf1c0a)Co-authored-by: Emma Smith <emma@emmatyping.dev>Co-authored-by: Gregory P. Smith <greg@krypto.org>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull requestAug 4, 2025
* Revert "pythongh-84481: Make ZipFile.data_offset more robust (python#132178)"This reverts commit6cd1d6c.* Revert "pythongh-84481: Add ZipFile.data_offset attribute (python#132165)"This reverts commit0788948.---------Co-authored-by: Gregory P. Smith <greg@krypto.org>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull requestAug 19, 2025
* Revert "pythongh-84481: Make ZipFile.data_offset more robust (python#132178)"This reverts commit6cd1d6c.* Revert "pythongh-84481: Add ZipFile.data_offset attribute (python#132165)"This reverts commit0788948.---------Co-authored-by: Gregory P. Smith <greg@krypto.org>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull requestSep 9, 2025
…-136950) (python#136955)pythongh-136170: Revert adding `ZipFile.data_offset` (pythonGH-136950)* Revert "pythongh-84481: Make ZipFile.data_offset more robust (pythonGH-132178)"This reverts commit6cd1d6c.* Revert "pythongh-84481: Add ZipFile.data_offset attribute (pythonGH-132165)"This reverts commit0788948.---------(cherry picked from commit6bf1c0a)Co-authored-by: Emma Smith <emma@emmatyping.dev>Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As pointed out by@picnixz, in append mode with a bad zip file, we append to the end of the file, and should set
.data_offset.I also added a test which should cover this scenario.