Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-131912: Use different grouping options for the integral and fractional parts#132170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 2 commits intopython:mainfromPrometheus3375:grouping-examples
Apr 7, 2025

Conversation

Prometheus3375
Copy link
Contributor

@Prometheus3375Prometheus3375 commentedApr 6, 2025
edited by picnixz
Loading

A small addition to#132030 discussed in#132123. There are many examples with_ used as digit group separator, but only one with,. I changed last two examples with floating-point number to include a comma separator. I believe it is sufficient to show that both options can be used for both integral and fractional parts, as well as the fact that a user can mix them.


📚Documentation preview 📚

@Prometheus3375
Copy link
ContributorAuthor

Prometheus3375 commentedApr 6, 2025
edited
Loading

It is a bit weird that only in the first example format string is rendered in bold. As if all others are not recognized by the renderer as a valid format.
image

@skirpichevskirpichev added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsApr 7, 2025
@skirpichev
Copy link
Contributor

It is a bit weird that only in the first example format string is rendered in bold.

Looks as a sphinx bug.@picnixz ?

@Prometheus3375
Copy link
ContributorAuthor

This one shouldn't be backported as 3.13 and below do not have grouping for fractional part.

skirpichev reacted with thumbs up emoji

@picnixz
Copy link
Member

Looks as a sphinx bug

That would be a Pygment issue in this case. Sphinx delegates highlighting to pygments.

@picnixzpicnixz removed needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsApr 7, 2025
@picnixzpicnixz self-requested a reviewApril 7, 2025 11:01
@skirpichev
Copy link
Contributor

Ah, indeed. Thanks.

The problem might be reported, seepygments/pygments#1340. Though, maybe it's a slightly different one.@Prometheus3375 would you like to investigate it and report to upstream?

@Prometheus3375
Copy link
ContributorAuthor

Looks to me as the same. I will provide an additional context in that issue.

@skirpichev
Copy link
Contributor

It might be different just because'_' separators were introduced in formatting mini-language later. Just a guess.

@Prometheus3375
Copy link
ContributorAuthor

They were introduced quite a while ago, in 3.6. Nethertheless, it is not the only place where highlighting does not occur. The same happens in a couple examples below like date format and nested formatting.

@picnixzpicnixz changed the titleUpdate grouping examplesgh-131912: Use different grouping options for the integral and fractional partsApr 7, 2025
@picnixzpicnixz merged commit3169743 intopython:mainApr 7, 2025
49 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsApr 7, 2025
@Prometheus3375Prometheus3375 deleted the grouping-examples branchApril 7, 2025 16:50
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@skirpichevskirpichevskirpichev approved these changes

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip issueskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Prometheus3375@skirpichev@picnixz@ZeroIntensity

[8]ページ先頭

©2009-2025 Movatter.jp