Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-130664: support '_' (just as ',') in Decimal's formatting#132155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
```pycon>>> from _decimal import Decimal as D>>> format(D(1234567), '_')'1_234_567'>>> format(D(1234567), '020_')'0_000_000_001_234_567'>>> format(D('1234.56'), '07_')'1_234.56'>>> format(D('1.23456789'), '_')'1.23456789'>>> format(D('123.456789'), '_%')'12_345.6789%'>>> from _pydecimal import Decimal as D>>> format(D(1234567), '_')'1_234_567'>>> format(D(1234567), '020_')'0_000_000_001_234_567'>>> format(D('1234.56'), '07_')'1_234.56'>>> format(D('1.23456789'), '_')'1.23456789'>>> format(D('123.456789'), '_%')'12_345.6789%'```All commit authors signed the Contributor License Agreement. |
| (',%','123.456789','12,345.6789%'), | ||
| (',e','123456','1.23456e+5'), | ||
| (',E','123456','1.23456E+5'), | ||
| # ... with '_' instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we not just use the existing tests with afor loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What you meant? There is no existing test with'_' separator.
StanFromIreland left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this not need a documentation update somewhere too?
Misc/NEWS.d/next/Library/2025-04-06-14-34-29.gh-issue-130664.JF2r-U.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…F2r-U.rstCo-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
skirpichev commentedApr 7, 2025
We don't have documentation for Decimal's formatting, beyond some notes in theFormat Specification Mini-Language. There are no even examples of formatted output (few added in#128698). |
e10fe81 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@skirpichev for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ythonGH-132155)(cherry picked from commite10fe81)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
GH-136649 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.