NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-77393: Add`--statistics` opt to`msgfmt.py`#132136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

StanFromIreland wants to merge7 commits intopython:main

base:main

Choose a base branch

fromStanFromIreland:msgfmt-stat

Open

gh-77393: Add`--statistics` opt to`msgfmt.py`#132136

StanFromIreland wants to merge7 commits intopython:mainfromStanFromIreland:msgfmt-stat

+47 −2

Conversation

Copy link

Contributor

StanFromIreland commentedApr 5, 2025•
edited
Loading

This PR also covers#53950
cc@tomasr8

Issue:add several options to msgfmt.py #77393

Add --statistics opt

d5deb58

bedevere-appbot added the awaiting review label

Apr 5, 2025

bedevere-appbot mentioned this pull request

Apr 5, 2025

add several options to msgfmt.py#77393

Closed

Make it like GNU msgfmt's option

3a9d5e2

StanFromIreland commented

Apr 5, 2025

View reviewed changes

Tools/i18n/msgfmt.py OutdatedShow resolvedHide resolved

Minor fix

e85a61a

tomasr8 reviewed

Apr 5, 2025

View reviewed changes

Copy link

Member

tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd also add a test for multiple input files

Lib/test/test_tools/test_msgfmt.pyShow resolvedHide resolved

Copy link

ContributorAuthor

StanFromIreland commentedApr 5, 2025

For multiple input it works like so:

2 translated messages.4 translated messages.

Is this the format we want (It is not the best, but then again the current situation is poor since it just silently passes anyway)? I cannot compare toGNU msgfmt here since it doesn't allow this.

Copy link

Member

tomasr8 commentedApr 5, 2025

For multiple input it works like so:
2 translated messages.4 translated messages.
Is this the format we want (It is not the best, but then again the current situation is poor since it just silently passes anyway)? I cannot compare toGNU msgfmt here since it doesn't allow this.

Just an idea, but maybe prefix each line with the filename in case more than one file is given?

Copy link

ContributorAuthor

StanFromIreland commentedApr 5, 2025

Just an idea, but maybe prefix each line with the filename in case more than one file is given?

I considered that, but then again do we also want that for single files, otherwise there is an even more complex printing system ;-) This will then be inconsistent with GNU msgfmt

Test multiple input files, also edge case (and as a result issue 5395…

898204b

…0) covered

Copy link

Member

tomasr8 commentedApr 5, 2025

Just an idea, but maybe prefix each line with the filename in case more than one file is given?
I considered that, but then again do we also want that for single files, otherwise there is an even more complex printing system ;-) This will then be inconsistent with GNU msgfmt

no, just when more than one file is given, so that it's consistent w/ GNU but still useful in the other case.

Add filenames for multiple inputs and fix test for windows

0b71e6e

StanFromIreland requested a review fromtomasr8

April 5, 2025 20:29

StanFromIreland marked this pull request as draft

April 5, 2025 20:39

bedevere-appbot removed the awaiting review label

Apr 5, 2025

Copy link

ContributorAuthor

StanFromIreland commentedApr 5, 2025

I think I need to fix something. I will look into it tomorrow, it seems off.

Fix empty translation counting

3c9fd26

StanFromIreland marked this pull request as ready for review

April 5, 2025 20:55

bedevere-appbot added the awaiting review label

Apr 5, 2025

StanFromIreland commented

Apr 5, 2025

View reviewed changes

Lib/test/test_tools/test_msgfmt.py

Comment on lines +177 to +181

		# Multiple input files
		res = assert_python_ok(msgfmt, '--statistics', '-o', 'temp.mo', data_dir / "general.po", data_dir / "fuzzy.po")
		out = res.out.decode('utf-8').strip()
		self.assertIn('general.po: 8 translated messages, 1 untranslated message.', out)
		self.assertIn('fuzzy.po: 0 translated messages.', out)