Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132063: ProcessPoolExecutor swallows falsy Exceptions#132129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

YvesDup
Copy link
Contributor

@YvesDupYvesDup commentedApr 5, 2025•
edited by bedevere-appbot
Loading

ProcessPoolExecutor and ThreadPoolExecutor swallows falsy exception.

Fix tests about exception variable in 2 files of /Lib/concurrent/futures

  • _base.py
  • process.py

Changes 2 tests as below:

Replaceif exception: withif exception is not None:

@python-cla-bot
Copy link

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I never sent my review.

@YvesDup
Copy link
ContributorAuthor

YvesDup commentedApr 7, 2025•
edited
Loading

After more tests, I found that__cause__,__context__ attributes in falsey exceptions are ignored.

if (eande.__cause__isnotNone

if (eande.__context__isnotNone

And falseyBaseExceptionGroup exception is ignored too.
ifeandisinstance(e,BaseExceptionGroup):

Should we open a new issue with these bugs or integrate them to this PR ?

EDIT: please ignore this comment

YvesDupand others added3 commitsApril 8, 2025 14:18
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some nits and LGTM.


msg = 'boolbool'
with self.assertRaisesRegex(FalseyBoolException, msg):
self.executor.submit(raiser, FalseyBoolException, msg).result()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is for a possible follow-up but this kind of call makes me wonder whether the base class shouldn't have somedef submit_and_fetch(self) method that does this.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this method return directy the result ?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is a follow-up with theTracebackExceptionclass which swallows__cause__ and__context__ content of falsey exceptions.
I will post a new issue about this.

@picnixzpicnixzenabled auto-merge (squash)April 8, 2025 14:55
@picnixzpicnixz added the needs backport to 3.13bugs and security fixes labelApr 8, 2025
@picnixzpicnixz merged commit933c665 intopython:mainApr 8, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks@YvesDup for the PR, and@picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 8, 2025
…alsey exceptions (pythonGH-132129)(cherry picked from commit933c665)Co-authored-by: Duprat <yduprat@gmail.com>
@bedevere-app
Copy link

GH-132275 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 8, 2025
picnixz pushed a commit that referenced this pull requestApr 8, 2025
…falsey exceptions (GH-132129) (#132275)gh-132063: ensure that `ProcessPoolExecutor` does not swallow falsey exceptions (GH-132129)(cherry picked from commit933c665)Co-authored-by: Duprat <yduprat@gmail.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
@YvesDupYvesDup deleted the ProcessPoolExecutor-swallows-flasy-exception branchMay 16, 2025 10:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@YvesDup@picnixz@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp