Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.13] gh-131912: Refactor description of grouping options in format specification docs (GH-132030)#132123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 10 commits intopython:3.13fromPrometheus3375:gh-131912-313
Apr 7, 2025

Conversation

Prometheus3375
Copy link
Contributor

@Prometheus3375Prometheus3375 commentedApr 5, 2025•
edited
Loading

Key changes from the original PR:

  1. grouping is placed afterwidth (in original PR it is afterprecision).
  2. Support for fractional part is not mentioned as it is introduced in 3.14.

📚Documentation preview 📚

@bedevere-appbedevere-appbot added awaiting review docsDocumentation in the Doc dir skip news labelsApr 5, 2025
@Prometheus3375Prometheus3375 changed the title[3.13] Refactor description of grouping options in format specification docs (GH-132030)[3.13] gh-131912: Refactor description of grouping options in format specification docs (GH-132030)Apr 5, 2025
@skirpichevskirpichev added the needs backport to 3.12only security fixes labelApr 5, 2025
@skirpichevskirpichev requested a review frompicnixzApril 5, 2025 13:18
@python-cla-bot
Copy link

All commit authors signed the Contributor License Agreement.

CLA signed

picnixz

This comment was marked as resolved.

@picnixz

This comment was marked as resolved.

@picnixzpicnixz self-assigned thisApr 6, 2025
@picnixz
Copy link
Member

I'll merge the PR tomorrow! thanks for the work

Prometheus3375 reacted with heart emoji

@Prometheus3375
Copy link
ContributorAuthor

Prometheus3375 commentedApr 6, 2025•
edited
Loading

I saw the question was resolved, but I still answer. I also updated PR description is well.

Here are changes compared to 3.14 (string copy.rst). It marksprecision as moved, becausegrouping is placed afterwidth here, but afterprecision in 3.14.

image
image
image
image

@picnixzpicnixz merged commit07483c2 intopython:3.13Apr 7, 2025
26 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsApr 7, 2025
@miss-islington-app
Copy link

Thanks@Prometheus3375 for the PR, and@picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 7, 2025
…e format specification docs (pythonGH-132030) (pythonGH-132123)(cherry picked from commit07483c2)Co-authored-by: Prometheus3375 <35541026+Prometheus3375@users.noreply.github.com>(cherry picked from commit06a110f)
@picnixz
Copy link
Member

I hope this won't have conflicts in 3.12.

@bedevere-app
Copy link

GH-132203 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelApr 7, 2025
@Prometheus3375Prometheus3375 deleted the gh-131912-313 branchApril 7, 2025 10:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@skirpichevskirpichevskirpichev left review comments

@picnixzpicnixzpicnixz approved these changes

Assignees

@picnixzpicnixz

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Prometheus3375@picnixz@skirpichev
[8]ページ先頭
©2009-2025 Movatter.jp