Movatterモバイル変換

serhiy-storchaka requested a review fromvstinner

April 5, 2025 08:48

github-project-automationbot added this toDocs PRs

github-project-automationbot moved this toTodo inDocs PRs

bedevere-appbot added the awaiting core review label

tomasr8 reviewed

Doc/library/socket.rst Outdated

		On FreeBSD, NetBSD and DragonFlyBSD it accepts ``bdaddr`` where ``bdaddr``
		is a :class:`bytes` object containing the Bluetooth address in a
		string format. (ex. ``b'12:23:34:45:56:67'``)
		On Linux it accepts a tuple ``(device_id,)`` where ``device_id``

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this BSD and Linux-only or are other OSes supported as well?

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The current doc says "everything else" accepts an integer.

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In code, it is "other OSes". But I have not found information about any other OSes that support this. Windows is not supported. Until recently, FreeBSD was in "other OSes", but this was a bug (see#131668).

Copy link

Contributor

StanFromIrelandApr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we add an.. availability: …?

picnixz removed the skip issue label

bedevere-appbot mentioned this pull request

Inconsistency in handling Bluetooth addresses#132099

Closed

StanFromIreland reviewed

Doc/library/socket.rst OutdatedShow resolvedHide resolved

Doc/library/socket.rst Outdated

		- :const:`BTPROTO_HCI` accepts format that depends on your OS.
		On FreeBSD, NetBSD and DragonFlyBSD it accepts ``bdaddr`` where ``bdaddr``
		is a :class:`bytes` object containing the Bluetooth address in a
		string format. (ex. ``b'12:23:34:45:56:67'``)

Copy link

Contributor

StanFromIrelandApr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	string format. (ex. ``b'12:23:34:45:56:67'``)
	string format. (For example: ``b'12:23:34:45:56:67'``)

We can expand IMO, the line is short anyway

Copy link

MemberAuthor

serhiy-storchakaApr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a copy from the documentation for BTPROTO_SCO. I do not want to diverge it without reasons.

Apply suggestions from code review

1c32480

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

StanFromIreland reviewed

Doc/library/socket.rst OutdatedShow resolvedHide resolved

Doc/library/socket.rst

		is a :class:`bytes` object containing the Bluetooth address in a
		string format. (ex. ``b'12:23:34:45:56:67'``)
		- On Linux it accepts a tuple ``(device_id,)`` where ``device_id``
		is an integer specifying the number of the Bluetooth device.

Copy link

Contributor

StanFromIrelandApr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change



	..availability::Linux, FreeBSD, NetBSD, DragonFlyBSD

Do we want to list officially unsupported os'es here?

Copy link

MemberAuthor

serhiy-storchakaApr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is noavailability directive for BTPROTO_L2CAP and BTPROTO_SCO, and I am not sure what we could write there.

Update Doc/library/socket.rst

e17e43e

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

serhiy-storchaka commented

Doc/library/socket.rst OutdatedShow resolvedHide resolved

serhiy-storchaka added2 commits

April 5, 2025 15:52

Update Doc/library/socket.rst

0e8b750

Clean up.

7bd9d06

Copy link

python-cla-botbot commentedApr 6, 2025

All commit authors signed the Contributor License Agreement.

serhiy-storchaka added the needs backport to 3.13bugs and security fixes label

Apr 9, 2025

serhiy-storchaka added2 commits

April 13, 2025 18:04

Merge branch 'main' into docs-bluetooth-hci

ac626d4

More tweaking.

113b9b4

serhiy-storchaka merged commit1d97488 intopython:main

24 checks passed

github-project-automationbot moved this fromTodo toDone inDocs PRs

Copy link

miss-islington-appbot commentedApr 13, 2025

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting core review label

Copy link

miss-islington-appbot commentedApr 13, 2025

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 1d97488c957f4595f8c3ea42e24c1995b23e39d4 3.13

miss-islington-appbot assignedserhiy-storchaka

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

[3.13]pythongh-132099: Fix documentation for the BTPROTO_HCI protocol (

6577051

pythonGH-132118)(cherry picked from commit1d97488)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Copy link

bedevere-appbot commentedApr 13, 2025

GH-132482 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

serhiy-storchaka added a commit that referenced this pull request