#if defined(MS_WINDOWS) && !defined(__clang__)#define _GENERATE_DEBUG_SECTION_WINDOWS(name)                       \   _Pragma(Py_STRINGIFY(section(Py_STRINGIFY(name), read, write))) \   __declspec(allocate(Py_STRINGIFY(name)))

should stay: clangcl might not understand__declspec(allocate(...)).

But then, noGENERATE_DEBUG_SECTION is in effect, because

#if defined(__linux__) && (defined(__GNUC__) || defined(__clang__))#define _GENERATE_DEBUG_SECTION_LINUX(name) \   __attribute__((section("." Py_STRINGIFY(name))))               \   __attribute__((used))

will never fire due to__linux__. Maybe rewrite that to

#if (defined(__linux__) && defined(__GNUC__)) || (defined(MS_WINDOWS) && defined(__clang__))#define _GENERATE_DEBUG_SECTION_LINUX(name) \   __attribute__((section("." Py_STRINGIFY(name))))               \   __attribute__((used))

clang defines__GNUC__, so I dropped the first__clang__

Copy link

Member

chris-eibl commentedApr 4, 2025

Ah - while I was typing you already had the same idea :)

Fidget-Spinner added2 commits

April 5, 2025 03:05

Update remote_debugging.c

07cafa9

Update remote_debugging.c

bd00b78

chris-eibl reviewed

Apr 4, 2025

View reviewed changes

Python/remote_debugging.c Outdated

		const char* secname = "_PyRuntime";
		#else
		const char* secname = "PyRuntime";
		#endif

Copy link

Member

chris-eiblApr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Use secname instead of "PyRuntime" below?

Copy link

MemberAuthor

Fidget-SpinnerApr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah oops 🤦 thanks 3AM things.

Update remote_debugging.c

04d34df

taegyunkim reviewed

Apr 4, 2025

View reviewed changes

.github/workflows/tail-call.yml

Comment on lines +117 to +118

		export PATH="/usr/local/opt/llvm/bin:$PATH"
		export PATH="/opt/homebrew/opt/llvm/bin:$PATH"

Copy link

taegyunkimApr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

wonder whether
eval "$(brew shellenv)"
is just enough for both intel and arm mac

Copy link

MemberAuthor

Fidget-SpinnerApr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's a good point. Let me try that later.

Copy link

MemberAuthor

Fidget-Spinner commentedApr 4, 2025

Well I have absolutely no clue what's going on with Windows here. Will sleep on it and let someone else take over. In the meantime, will just use this PR to upgrade the LLVM version.

chris-eibl reviewed

Apr 4, 2025

View reviewed changes

Python/remote_debugging.c OutdatedShow resolvedHide resolved

chris-eibl mentioned this pull request

Apr 5, 2025

gh-131591: Fix GENERATE_DEBUG_SECTION for clangcl on Windows#132112

Merged

Copy link

Member

chris-eibl commentedApr 5, 2025

@Fidget-Spinner: I've created#132112 to fixGENERATE_DEBUG_SECTION for clangcl on Windows. CI is green. Feel free to incorporate it in this PR if you want - I'll then just close it.