NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-118761: Optimise import time for`shlex`#132036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

AA-Turner merged 6 commits intopython:mainfromAA-Turner:opt-shlex

Apr 24, 2025

Merged

gh-118761: Optimise import time for`shlex`#132036

AA-Turner merged 6 commits intopython:mainfromAA-Turner:opt-shlex

Apr 24, 2025

Conversation

Copy link

Member

AA-Turner commentedApr 2, 2025•
edited
Loading

This PR achieves a 33x improvement in import time for theshlex module and a 4-12x improvement in performance forshlex.quote.

Current:

import shlex: cumulative timemean: 9065.967 µsmedian: 9092.000 µsstdev: 282.015min: 8587max: 9556

This PR:

import shlex: cumulative timemean: 274.300 µsmedian: 275.000 µsstdev: 8.860min: 259max: 289

Issue:Improve import time of various stdlib modules #118761

Optimise import time forshlex

1fd83f1

AA-Turner added the performancePerformance or resource usage label

Apr 2, 2025

bedevere-appbot added the awaiting core review label

Apr 2, 2025

bedevere-appbot mentioned this pull request

Apr 2, 2025

Improve import time of various stdlib modules#118761

Open

rruuaanng approved these changes

Apr 3, 2025

View reviewed changes

Copy link

Member

JelleZijlstra commentedApr 4, 2025

I'm not sure this is practically useful, since pretty much anything you'd do within the module will trigger the imports. Also, importingsys andio is practically free since they're imported at startup.

Revert deferral of sys and io

8811463

Copy link

MemberAuthor

AA-Turner commentedApr 4, 2025•
edited
Loading

True, this one is more marginal.quote andjoin will only importre, whereassplit andshlex will importcollections/os.path. Whereshlex is used in the stdlib, it's often only one of these two groups, so I think it could still have benefits?

Edit:quote andjoin now no longer importre