Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-85302: Add support for BTPROTO_SCO on FreeBSD#131981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-85302: Add support for BTPROTO_SCO on FreeBSD#131981
Uh oh!
There was an error while loading.Please reload this page.
Conversation
BTPROTO_SCO has been supported on FreeBSD since 2008.
!buildbot FreeBSD |
bedevere-bot commentedApr 1, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commit2debf1e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
With this change,socket.BTPROTO_SCO constant does not exist on FreeBSD which makes the whole change useless.
The problem is that on my FreeBSD 14.1 VM, the constant is not defined anywhere.grep finds nothing:
$ grep BTPROTO_SCO /usr/include/ -RAre you sure that FreeBSD supports BTPROTO_SCO?
Indeed, it is defined as BLUETOOTH_PROTO_SCO. I'll fix this, but first we need to add tests. See#132023. |
!buildbot FreeBSD |
bedevere-bot commentedApr 4, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commit2debf1e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
You need to update your PR to use BLUETOOTH_PROTO_SCO constant, no? |
Did I forget to push my changes? Thanks for noticing. |
!buildbot FreeBSD |
bedevere-bot commentedApr 4, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commita62570a 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
All commit authors signed the Contributor License Agreement. |
e5f8b2c intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
BTPROTO_SCO has been supported on FreeBSD since 2008.
📚 Documentation preview 📚:https://cpython-previews--131981.org.readthedocs.build/