Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-131938: Update error message forElement.remove() when an element is not found#131972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedApr 1, 2025•
edited by bedevere-appbot
Loading

@picnixz
Copy link
MemberAuthor

@vstinner You suggested this in the other PR, but I don't know if you want me to align the Python implementation as well. More generally, what's the policy when we have a C and a Python implementation: should the exception messages match as much as possible or is it fine to have discrepencies?

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Co-authored-by: Victor Stinner <vstinner@python.org>
@picnixz
Copy link
MemberAuthor

I'm actually leaving now so won't have time to push this, I'll do it on Friday though!

@picnixzpicnixz self-assigned thisApr 1, 2025
@picnixzpicnixzenabled auto-merge (squash)April 4, 2025 13:14
@vstinner
Copy link
Member

The Windows x64 job failed with a network issue (urllib.error.HTTPError: HTTP Error 504: Gateway Timeout). I restarted the job.

picnixz reacted with heart emoji

@picnixzpicnixz merged commit04bc681 intopython:mainApr 4, 2025
44 checks passed
@picnixzpicnixz deleted the feat/xml/remove-error-message-131938 branchApril 8, 2025 10:58
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
… an element is not found (python#131972)The exception message for `xml.etree.ElementTree.Element.remove` when an element is not foundhas been updated from "list.remove(x): x not in list" to "Element.remove(x): element not found".
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

@picnixzpicnixz

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp