Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130655: Add a test for corrupt MO files in gettext#131911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 2 commits intopython:mainfromtomasr8:gettext-corrupt
Apr 4, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedMar 30, 2025•
edited by bedevere-appbot
Loading

It is possible to have a corrupt MO file where the message offsets and lengths are larger than the size of the file being parsed. gettext detects this and raises an error, however this is currently not tested. This PR adds a test for it.

@bedevere-appbedevere-appbot added testsTests in the Lib/test dir awaiting review labelsMar 30, 2025
@tomasr8tomasr8 added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsMar 30, 2025
picnixz
picnixz previously requested changesMar 30, 2025
@bedevere-app

This comment was marked as resolved.

@picnixz
Copy link
Member

sry misclick, I wanted to abandon a pending review :')

@picnixzpicnixz self-requested a reviewMarch 30, 2025 19:30
@picnixzpicnixzenabled auto-merge (squash)April 4, 2025 13:01
@picnixzpicnixzdisabled auto-mergeApril 4, 2025 13:01
@picnixzpicnixzenabled auto-merge (squash)April 4, 2025 13:02
@picnixzpicnixz merged commita126cef intopython:mainApr 4, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@tomasr8 for the PR, and@picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 4, 2025
…honGH-131911)(cherry picked from commita126cef)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 4, 2025
…honGH-131911)(cherry picked from commita126cef)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-132079 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 4, 2025
@bedevere-app
Copy link

GH-132080 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelApr 4, 2025
@tomasr8
Copy link
MemberAuthor

Thanks for the review@picnixz!

@tomasr8tomasr8 deleted the gettext-corrupt branchApril 4, 2025 13:52
picnixz pushed a commit that referenced this pull requestApr 4, 2025
…-131911) (#132079)gh-130655: Add a test for corrupt `.mo` files in `gettext` (GH-131911)(cherry picked from commita126cef)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
picnixz pushed a commit that referenced this pull requestApr 4, 2025
…-131911) (#132080)gh-130655: Add a test for corrupt `.mo` files in `gettext` (GH-131911)(cherry picked from commita126cef)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@tomasr8@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp