Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-130655: Add a test for bad magic numbers when parsing gettext MO files#131909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 4 commits intopython:mainfromtomasr8:gettext-magic
Apr 4, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedMar 30, 2025
edited by bedevere-appbot
Loading

We're currently not testing that MO files with invalid magic numbers are properly rejected. This PR adds a test for it.

@bedevere-appbedevere-appbot added testsTests in the Lib/test dir awaiting review labelsMar 30, 2025
@tomasr8tomasr8 added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsMar 30, 2025
@tomasr8tomasr8 requested a review frompicnixzApril 2, 2025 12:09
@picnixzpicnixzenabled auto-merge (squash)April 4, 2025 13:03
@picnixzpicnixz merged commit16a6270 intopython:mainApr 4, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@tomasr8 for the PR, and@picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 4, 2025
…ed by `gettext` (pythonGH-131909)(cherry picked from commit16a6270)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 4, 2025
…ed by `gettext` (pythonGH-131909)(cherry picked from commit16a6270)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-132077 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 4, 2025
@bedevere-app
Copy link

GH-132078 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelApr 4, 2025
@tomasr8tomasr8 deleted the gettext-magic branchApril 4, 2025 13:52
picnixz pushed a commit that referenced this pull requestApr 4, 2025
…sed by `gettext` (GH-131909) (#132077)gh-130655: Add a test for bad magic numbers in `.mo` files parsed by `gettext` (GH-131909)(cherry picked from commit16a6270)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
picnixz pushed a commit that referenced this pull requestApr 4, 2025
…sed by `gettext` (GH-131909) (#132078)gh-130655: Add a test for bad magic numbers in `.mo` files parsed by `gettext` (GH-131909)(cherry picked from commit16a6270)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@tomasr8@picnixz

[8]ページ先頭

©2009-2025 Movatter.jp