NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

[3.12] gh-128770: raise warnings as errors in test suite - except for test_s…#131824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

graingert wants to merge6 commits intopython:3.12fromgraingert:backport-8a00c9a-3.12

Closed

[3.12] gh-128770: raise warnings as errors in test suite - except for test_s…#131824

graingert wants to merge6 commits intopython:3.12fromgraingert:backport-8a00c9a-3.12

Conversation

Copy link

Contributor

graingert commentedMar 28, 2025•
edited by bedevere-appbot
Loading

…ocket which still logs warnings, and internal test warnings that are now logged (#128973)

Co-authored-by: Bénédikt Tran10796600+picnixz@users.noreply.github.com
(cherry picked from commit8a00c9a)

Issue:configure warnings as errors in the test suite #128770

pythongh-128770: raise warnings as errors in test suite - except for …

3c06656

…test_socket which still logs warnings, and internal test warnings that are now logged (python#128973)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>(cherry picked from commit8a00c9a)

bedevere-appbot mentioned this pull request

Mar 28, 2025

configure warnings as errors in the test suite#128770

Closed

graingert commented

Mar 28, 2025

View reviewed changes

Lib/test/support/__init__.py OutdatedShow resolvedHide resolved

graingert added2 commits

March 28, 2025 07:50

Update Lib/test/support/__init__.py

e42a39c

add ExtraAssertions to test_support

43af621

graingert added the skip news label

Mar 28, 2025

graingert changed the title~~gh-128770: raise warnings as errors in test suite - except for test_s…~~[3.12] gh-128770: raise warnings as errors in test suite - except for test_s…

Mar 28, 2025

bedevere-appbot mentioned this pull request

Mar 28, 2025

gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings, and internal test warnings that are now logged#128973

Merged

graingert marked this pull request as ready for review

March 28, 2025 08:57

graingert requested review fromrhettinger andtiran ascode owners

March 28, 2025 08:57

bedevere-appbot added the awaiting review label

Mar 28, 2025

graingert requested a review fromhugovk

March 28, 2025 08:58

Merge branch '3.12' into backport-8a00c9a-3.12

c719cc5

rhettinger removed their request for review

March 28, 2025 21:24

Merge branch '3.12' into backport-8a00c9a-3.12

03583e7

Copy link

python-cla-botbot commentedApr 6, 2025

All commit authors signed the Contributor License Agreement.

Merge branch '3.12' into backport-8a00c9a-3.12

cdf5ad9

Copy link

Member

Yhg1s commentedApr 8, 2025

Let's not do this in 3.12 at this point. The next release is the last bugfix release, the value of surfacing warnings is mostly in the long term (making sure future changes don't introduce new warnings), and this has the potential of creating unexpected and possibly irrelevant failures in the test suite, in particular in corner cases not covered by our buildbots. We won't see many new changes in 3.12 after this, and we won't have a lot of opportunities to fix the test failures this might uncover.