@Wulian233 In your benchmark thesqlite3_new is slower (takes more time to import). Based on the name I would expect it to be the faster one.

Alsotime is a builtin module. Is that one really a bottleneck?

I'm also a bit surprised thattime would be a bottleneck. When I run./python -X importtime -c 'import sqlite3' on my system, I get

import time: self [us] | cumulative | imported package[...]import time:        80 |         80 |   time[...]import time:      2011 |       8096 | sqlite3

Which, if I'm reading it right, says that importingtime can only account for only a small fractionsqlite3's import time?

@Wulian233 In your benchmark thesqlite3_new is slower (takes more time to import). Based on the name I would expect it to be the faster one.

Alsotime is a builtin module. Is that one really a bottleneck?

I think I got the name wrong at the time, it was a copy of the previous PR content, and here is the test I just run

D:\Python313>hyperfine -i --warmup 8 "./python -c 'from sqlite3 import *'" "./python -c 'from sqlite3_new import *'"Benchmark 1: ./python -c 'from sqlite3 import *'  Time (mean ± σ):     697.1 µs ± 1059.7 µs    [User: 2577.5 µs, System: 3063.5 µs]  Range (min … max):     0.0 µs … 10960.7 µs    391 runs  Warning: Command took less than 5 ms to complete. Note that the results might be inaccurate because hyperfine can not calibrate the shell startup time much more precise than this limit. You can try to use the `-N`/`--shell=none` option to disable the shell completely.  Warning: Ignoring non-zero exit code.  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.Benchmark 2: ./python -c 'from sqlite3_new import *'  Time (mean ± σ):     635.0 µs ± 755.4 µs    [User: 1821.0 µs, System: 3691.3 µs]  Range (min … max):     0.0 µs … 3622.5 µs    399 runs  Warning: Command took less than 5 ms to complete. Note that the results might be inaccurate because hyperfine can not calibrate the shell startup time much more precise than this limit. You can try to use the `-N`/`--shell=none` option to disable the shell completely.  Warning: Ignoring non-zero exit code.Summary  ./python -c 'from sqlite3_new import *' ran    1.10 ± 2.12 times faster than ./python -c 'from sqlite3 import *'

To be precise, it's not importingsqlite3 that is faster, it's importingsqlite3and loading its content in the global namespace (the benchmarks are done forfrom sqlite3 import * not for a plainimport sqlite3 statement).

Also, the benchmarks are quite unstable. The standard deviation is much higher than the mean itself! In practice, I think we don't gain anything else than stability (the stdev becomes smaller with the new implementation but again this could be noise).

Can you check ifimport sqlite3 has less noise?

And to be precise, we're not gaining a 2x speed-up. On average, we're only gaining a 1.1x speed-up and the standard deviation of this speed-up is$\pm2$, which is again not really indicative =/

And yes, I'm also surprised that we're gaining "that much" when we just makeimport time local. Considering it's a built-in module (though not sure if it's present at startup), I don't think we need to do this change (we're maybe gaining a small speed-up but maybe not much; and sqlite3 is already is a heavy module to import). So benchmarks using-X importtime here are much more important IMO compared to interpreter's startup as well.