NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

bpo-36829: Add a -X option to abort in PyErr_WriteUnraisable()#13175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ZackerySpytz wants to merge1 commit intopython:masterfromZackerySpytz:bpo-36829-X-option-PyErr_WriteUnraisable

Closed

bpo-36829: Add a -X option to abort in PyErr_WriteUnraisable()#13175

ZackerySpytz wants to merge1 commit intopython:masterfromZackerySpytz:bpo-36829-X-option-PyErr_WriteUnraisable

Conversation

Copy link

Contributor

ZackerySpytz commentedMay 7, 2019•
edited by bedevere-bot
Loading

Add a -X command-line option to abort the current process
if PyErr_WriteUnraisable() is called.

https://bugs.python.org/issue36829

bpo-36829: Add a -X option to abort in PyErr_WriteUnraisable()

b6ee066

Add a -X command-line option to abort the current processif PyErr_WriteUnraisable() is called.

ZackerySpytz requested a review fromgpshead as acode owner

May 7, 2019 20:22

the-knights-who-say-ni added the CLA signed label

May 7, 2019

bedevere-bot added the awaiting review label

May 7, 2019

Copy link

Member

matrixise commentedMay 7, 2019

Hi@ZackerySpytz

Do you think you could add a test?

Copy link

Member

vstinner commentedMay 7, 2019

I am not sure I like this feature. Would it make sense to add a callback instead, like sys.excepthook? The callback could log the error, do nothing, abort the process, call the police, etc. It might be more general, no?

Copy link

Contributor

graingert commentedMay 7, 2019

@vstinner PyErr_WriteUnraisable can get called during__del__ or GC so most of the python environment could have already been deleted by the time the hook is called,

Or the hook could be called after the hook is removed by GC and then we're back to the same problem