Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-127146: Fix Emscripten build with --pydebug#131672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-127146: Fix Emscripten build with --pydebug#131672
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The deleted logic checks that the sysconfigdata is in a short list,and the list does not allow the `d` ABI flag to be present. I removedthe check because I don't think it is helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 Seems reasonable. If the build is generating the wrong sysconfigdata name, other things are going to explode; and with the new error reporting, that's going to be a lot easier to diagnose.
97ab8fc intopython:mainUh oh!
There was an error while loading.Please reload this page.
Removes an explicit check that sysconfigdata naming is correct, in favor of reporting atruntime with the default mechanisms.
Removes an explicit check that sysconfigdata naming is correct, in favor of reporting atruntime with the default mechanisms.
Uh oh!
There was an error while loading.Please reload this page.
The deleted logic checks that the sysconfigdata is in a short list, and the list does not allow the
dABI flag to be present so it fails if we build with--with-pydebug. I removed the check because I don't think it is helpful.