Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
GH-130798: Add type hints to pathlib.types#131639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ap-- wants to merge19 commits intopython:mainChoose a base branch fromap--:pathlib-types-add-typehints
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
19 commits Select commitHold shift + click to select a range
3d9816b
Add typehints to pathlib.types
ap--310c245
Iterator type for .glob and .iterdir
ap--399a213
Merge remote-tracking branch 'origin/main' into pathlib-types-add-typ…
ap--d1583c0
Update types
ap--50a8f88
Update pathlib.types to use Self
ap--e21b884
Rely on python3.13 Generator defaults
ap--b004c2d
Switch walk to Iterator[...]
ap--b1de80e
Use abstract base classes from collections.abc
ap--4aa2540
Use _PathParser in _explode_path
ap--54acfa3
Rename TypeVar to _WritablePathT
ap--d2dc4b1
Move _explode_path
ap--44b1b6f
Update Lib/pathlib/types.py
ap--aace9d0
Merge remote-tracking branch 'origin/main' into pathlib-types-add-typ…
ap--73d79da
pathlib.types: don't rely on typing.Optional
ap--965c3c7
avoid typing imports that are not needed at runtime
ap--b952ab0
add pathlib to Misc/mypy tests
ap--d83531f
pathlib: fix most typing issues
ap--e596130
prevent missing glob typing to bleed into _pyrepl mypy tests
ap--7cd07f1
workaround crashing mypy
ap--File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Rename TypeVar to _WritablePathT
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit54acfa3879acb087ae1415237a343d31c8d695d5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -20,7 +20,7 @@ | ||
runtime_checkable, | ||
) | ||
_WritablePathT = TypeVar("_WritablePathT", bound="_WritablePath") | ||
def _explode_path(path: str, parser: "_PathParser") -> tuple[str, list[str]]: | ||
ap-- marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
@@ -345,15 +345,15 @@ def readlink(self) -> Self: | ||
""" | ||
raise NotImplementedError | ||
def copy(self, target:_WritablePathT, **kwargs: Any) ->_WritablePathT: | ||
""" | ||
Recursively copy this file or directory tree to the given destination. | ||
""" | ||
ensure_distinct_paths(self, target) | ||
target._copy_from(self, **kwargs) | ||
return target.joinpath() # Empty join to ensure fresh metadata. | ||
def copy_into(self, target_dir:_WritablePathT, **kwargs: Any) ->_WritablePathT: | ||
""" | ||
Copy this file or directory tree into the given existing directory. | ||
""" | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.