Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-131434: Improve error reporting for incorrect format in strptime()#131568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedMar 21, 2025•
edited by bedevere-appbot
Loading

In particularly, fix regression in detecting stray % at the end of the format string.

…time()In particularly, fix regression in detecting stray % at the end of theformat string.
@@ -0,0 +1 @@
Improve error reporting for incorrect format in :func:`time.strptime`.
Copy link
Contributor

@StanFromIrelandStanFromIrelandMar 21, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Improve error reporting for incorrect format in:func:`time.strptime`.
Fix error reporting for incorrect format in:func:`time.strptime`.

It worked before ;-)

Also datetime strptime functions are affected.

I will review it more in detail later. It looks good from a glance

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixing the case for ending% is just a part of this PR. It improves error reporting for many more cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see, It was however also datetime strptimes

@serhiy-storchakaserhiy-storchaka merged commit3feac7a intopython:mainApr 9, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchakaserhiy-storchaka deleted the strptime-bad-format branchApril 9, 2025 10:26
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 9, 2025
…time() (pythonGH-131568)In particularly, fix regression in detecting stray % at the end of theformat string.(cherry picked from commit3feac7a)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 3feac7a093b3fcd549c5dc54277f26f585f2ab0c 3.12

@bedevere-app
Copy link

GH-132309 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 9, 2025
@serhiy-storchakaserhiy-storchaka removed the needs backport to 3.12only security fixes labelApr 9, 2025
serhiy-storchaka added a commit that referenced this pull requestApr 9, 2025
…ptime() (GH-131568) (GH-132309)In particularly, fix regression in detecting stray % at the end of theformat string.(cherry picked from commit3feac7a)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable LTO + PGO 3.13 (tier-2) has failed when building commite2d13b4.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1433/builds/637) and take a look at the build logs.
  4. Check if the failure is related to this commit (e2d13b4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1433/builds/637

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_perf_profiler.py", line356, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertIn(f"py::foo:{script}", stdout)~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'py::foo:/tmp/test_python_f6ntk2lc/tmpvnje2jz7/perftest.py' not found in 'python 1605731 1357156.266626:          1 cycles:Pu: \n\t    ffffa13c6ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1605731 1357156.266650:          1 cycles:Pu: \n\t    ffffa13c6ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1605731 1357156.267067:          1 cycles:Pu: \n\t    ffffa13c9370 strcmp+0x70 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13b3c27 check_match+0x147 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13b4017 do_lookup_x+0x397 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13b4833 _dl_lookup_symbol_x+0x113 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13b86ff resolve_map+0x79f (inlined)\n\t    ffffa13b86ff elf_machine_rela+0x79f (inlined)\n\t    ffffa13b86ff elf_dynamic_do_Rela+0x79f (inlined)\n\t    ffffa13b86ff _dl_relocate_object+0x79f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13c43d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13c15ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13c2b17 _dl_start_final+0x5ab (inlined)\n\t    ffffa13c2b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13c6ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1605731 1357156.267089:        429 cycles:Pu: \n\t    ffffa13b8638 elf_dynamic_do_Rela+0x6d8 (inlined)\n\t    ffffa13b8638 _dl_relocate_object+0x6d8 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13c43d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13c15ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13c2b17 _dl_start_final+0x5ab (inlined)\n\t    ffffa13c2b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa13c6ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1605731 1357156.268081:       1671 cycles:Pu: \n\t          47dd64 pysiphash+0x1c4 (inlined)\n\t          47dd64 _Py_HashBytes+0x1c4 (inlined)\n\t          47dd64 unicode_hash+0x1c4 (inlined)\n\t          47dd64 unicode_hash+0x1c4 (inlined)\n\t          47dd64 hashtable_unicode_hash+0x1c4 (inlined)\n\t          47dd64 _Py_hashtable_get_entry_generic+0x1c4 (inlined)\n\t          47dd64 _Py_hashtable_get+0x1c4 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5811cf intern_static.isra.0+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          58075b _PyUnicode_InternStatic+0x237b (inlined)\n\t          58075b init_global_interned_strings+0x237b (inlined)\n\t          58075b _PyUnicode_InitGlobalObjects+0x237b (inlined)\n\t          58075b pycore_init_global_objects+0x237b (inlined)\n\t          58075b pycore_interp_init+0x237b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578cb3 pyinit_config+0x413 (inlined)\n\t          578cb3 pyinit_core.constprop.0+0x413 (/home/buildbotrators+0x9ef (inlined)\n\t          582bb3 type_ready_fill_dict+0x9ef (inlined)\n\t          582bb3 type_ready+0x9ef (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          58209f init_static_type+0xbf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          58162f _PyTypes_InitTypes+0x43 (inlined)\n\t          58162f pycore_init_types+0x43 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5808ab pycore_interp_init+0x24cb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578cb3 pyinit_config+0x413 (inlined)\n\t          578cb3 pyinit_core.constprop.0+0x413 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578803 Py_InitializeFromConfig+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576b2f pymain_init+0xc3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5769f3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576963 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffffa115625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffa115633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          5755af _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npython 1605731 1357156.269152:     189846 cycles:Pu: \n\t          4819fc compare_unicode_unicode+0xdc (inlined)\n\t          4819fc do_lookup+0xdc (inlined)\n\t          4819fc unicodekeys_lookup_unicode+0xdc (inlined)\n\t          4819fc _Py_dict_lookup+0xdc (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          486d27 dict_setdefault_ref_lock_held+0x9f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          583307 type_add_members+0x1143 (inlined)\n\t          583307 type_ready_fill_dict+0x1143 (inlined)\n\t          583307 type_ready+0x1143 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          58209f init_static_type+0xbf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          58162f _PyTypes_InitTypes+0x43 (inlined)\n\t          58162f pycore_init_types+0x43 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5808ab pycore_interp_init+0x24cb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578cb3 pyinit_config+0x413 (inlined)\n\t          578cb3 pyinit_core.constprop.0+0x413 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578803 Py_InitializeFromConfig+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576b2f pymain_init+0xc3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5769f3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576963 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffffa115625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffa115633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          5755af _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npython 1605731 1357156.269582:     662178 cycles:Pu: \n\t    ffffa11c9020 alloc_perturb+0x0 (/usr/lib64/libc.so.6)\n\t    ffffa11cc8d3 _int_malloc+0xcd3 (/usr/lib64/libc.so.6)\n\t    ffffa11cd5cb malloc+0x22b (/usr/lib64/libc.so.6)\n\t          483b03 _PyMem_RawMalloc+0x2df (inlined)\n\t          483b03 PyMem_RawMalloc+0x2df (inlined)\n\t          483b03 _PyObject_Malloc+0x2df (inlined)\n\t          48Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/threading.py", line1041, in_bootstrap_innerself.run()~~~~~~~~^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/threading.py", line992, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_interpreters/test_stress.py", line30, intask    interp= interpreters.create()  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedkTraceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_perf_profiler.py", line356, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertIn(f"py::foo:{script}", stdout)~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'py::foo:/tmp/test_python_k2v2pzja/tmpo74ztd7v/perftest.py' not found in 'python 1598351 1357087.217905:          1 cycles:Pu: \n\t    ffffb125cac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1598351 1357087.217942:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffffb125cac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1598351 1357087.218056:          1 cycles:Pu: \n\t    ffffb12586ec elf_get_dynamic_info+0x180 (inlined)\n\t    ffffb12586ec _dl_start+0x180 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb125cad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1598351 1357087.218086:        334 cycles:Pu: \n\t    ffffb12587f8 _dl_start+0x28c (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb125cad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1598351 1357087.219115:       3976 cycles:Pu: \n\t    ffffb124a774 _dl_new_hash+0x54 (inlined)\n\t    ffffb124a774 _dl_lookup_symbol_x+0x54 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb124e6ff resolve_map+0x79f (inlined)\n\t    ffffb124e6ff elf_machine_rela+0x79f (inlined)\n\t    ffffb124e6ff elf_dynamic_do_Rela+0x79f (inlined)\n\t    ffffb124e6ff _dl_relocate_object+0x79f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb125a3d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb12575ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb1258b17 _dl_start_final+0x5ab (inlined)\n\t    ffffb1258b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb125cad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1598351 1357087.219201:     156051 cycles:Pu: \n\t    ffffb1249fd0 do_lookup_x+0x350 (/usr/lib/ld-linux-aarchiltin+0x597 (inlined)\n\t          581b83 _PyErr_InitTypes+0x597 (inlined)\n\t          581b83 pycore_init_types+0x597 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5808ab pycore_interp_init+0x24cb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578cb3 pyinit_config+0x413 (inlined)\n\t          578cb3 pyinit_core.constprop.0+0x413 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578803 Py_InitializeFromConfig+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576b2f pymain_init+0xc3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5769f3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576963 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffffb0ff625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffb0ff633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          5755af _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npython 1598351 1357087.229745:    9646811 cycles:Pu: \n\t          58df00 find_frozen+0x20 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5b5e57 _imp_find_frozen_impl+0x4b (inlined)\n\t          5b5e57 _imp_find_frozen+0x4b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          4c6dd3 cfunction_vectorcall_FASTCALL_KEYWORDS+0xb3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          4ad063 PyObject_Call+0x4b3b (inlined)\n\t          4ad063 PyCFunction_Call+0x4b3b (inlined)\n\t          4ad063 _PyEval_EvalFrameDefault+0x4b3b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          4d0703 _PyObject_VectorcallTstate+0x463 (inlined)\n\t          4d0703 object_vacall+0x463 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          50c7ff PyObject_CallMethodObjArgs+0x9f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5082c7 import_find_and_load+0x1d7 (inlined)\n\t          5082c7 PyImport_ImportModuleLevelObject+0x1d7 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          4af2e3 import_name+0x6dbb (inlined)\n\t          4af2e3 _PyEval_EvalFrameDefault+0x6dbb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5896cf _PyObject_VectorcallTstate.lto_priv.2+0x3f (inlined)\n\t          59c95b callmethod+0x4b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          59c3ff PyObject_CallMethod+0x8f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5a305f init_importlib_external+0x9f (inlined)\n\t          5a305f _PyImport_InitExternal+0x9f (inlined)\n\t          5a305f init_interp_main+0x9f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5a2f2f pyinit_main+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578823 Py_InitializeFromConfig+0x53 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576b2f pymain_init+0xc3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5769f3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576963 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffffb0ff625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffb0ff633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          5755af _start+0

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable Refleaks 3.x (tier-2) has failed when building commit3feac7a.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/123/builds/917) and take a look at the build logs.
  4. Check if the failure is related to this commit (3feac7a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/123/builds/917

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated
  • test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line364, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertIn(f"py::foo:{script}", stdout)~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'py::foo:/tmp/test_python_dokak1g2/tmppwaw0j4q/perftest.py' not found in 'python 1727191 1358391.835859:          1 cycles:Pu: \n\t    ffff8a48dac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1727191 1358391.835898:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff8a48dac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1727191 1358391.836076:          1 cycles:Pu: \n\t    ffff8a48d9e0 __sbrk+0x0 (inlined)\n\t    ffff8a4885cf _dl_sysdep_start+0x1af (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a489b17 _dl_start_final+0x5ab (inlined)\n\t    ffff8a489b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a48dad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1727191 1358391.836096:        333 cycles:Pu: \n\t    ffff8a489e00 dl_main+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a4885ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a489b17 _dl_start_final+0x5ab (inlined)\n\t    ffff8a489b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a48dad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1727191 1358391.837132:       2634 cycles:Pu: \n\t    ffff8a47f778 elf_machine_rela+0x818 (inlined)\n\t    ffff8a47f778 elf_dynamic_do_Rela+0x818 (inlined)\n\t    ffff8a47f778 _dl_relocate_object+0x818 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a48b3d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a4885ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a489b17 _dl_start_final+0x5ab (inlined)\n\t    ffff8a489b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8a48dad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1727191 1358391.837226:     156436 cycles:Pu: \n\t    ffff8a47b774 _dl_new_hash+0x54 (inlined)\n\t    ffff8a47b774 _dl_lookup_symbol_x+0x54 (/usr/     51e350 pymalloc_free+0x40 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          51e567 _PyObject_Free+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          508867 _PyMem_DebugRawFree+0x6f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5088ab _PyMem_DebugFree+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          51ee53 PyObject_Free+0x1f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5554f3 unicode_dealloc+0x123 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          50346b _Py_Dealloc+0x87 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          54ed6f Py_DECREF+0x63 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          55b1d3 intern_common+0x153 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58df47 _PyUnicode_InternMortal+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e003 PyUnicode_InternFromString+0x1f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4b24df descr_new+0x43 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4b3563 PyDescr_NewMethod+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5363c7 type_add_method+0x103 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          53646f type_add_methods+0x2b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5369df type_ready_fill_dict+0x1f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          543cfb type_ready+0x93 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          543f87 init_static_type+0x1a7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          54408b _PyStaticType_InitBuiltin+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          502e57 _PyTypes_InitTypes+0xa7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66a4b3 pycore_init_types+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66ab57 pycore_interp_init+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66ad53 pyinit_config+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672633 pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          67270b Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a46f7 pymain_init+0xff (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a47c7 pymain_main+0xf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a485b Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41f2f7 main+0xb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff8a22625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8a22633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41f1ef _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 1727191 1358391.846843:    8664500 cycles:Pu: \n\t          503260 _Py_SetImmortalUntracked+0x48 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          50423b _Py_SetImmortal+0x27 (/homeTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line388, intest_python_calls_do_not_appear_in_the_stack_if_perf_deactivatedself.assertEqual(stderr,"")~~~~~~~~~~~~~~~~^^^^^^^^^^^^AssertionError:'Warning:\nProcessed 498 events and lost 1[34 chars]\n\n' != ''- Warning:- Processed 498 events and lost 1 chunks!- - Check IO/CPU overload!- Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line364, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertIn(f"py::foo:{script}", stdout)~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'py::foo:/tmp/test_python__vxkoha5/tmpqgqg505f/perftest.py' not found in 'python 1787385 1359244.238669:          1 cycles:Pu: \n\t    ffff9957eac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1787385 1359244.238688:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff9957eac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1787385 1359244.239061:          1 cycles:Pu: \n\t    ffff995700e0 _dl_relocate_object+0x180 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9957c3d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff995795ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9957ab17 _dl_start_final+0x5ab (inlined)\n\t    ffff9957ab17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9957ead3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1787385 1359244.239077:        363 cycles:Pu: \n\t    ffff995700e8 _dl_relocate_object+0x188 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9957c3d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff995795ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9957ab17 _dl_start_final+0x5ab (inlined)\n\t    ffff9957ab17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9957ead3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 1787385 1359244.240097:       1549 cycles:Pu: \n\t          538c00 _PyType_InitCache+0x44 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          674257 init_interpreter+0x9f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          67566f _PyInterpreterState_New+0xc7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66a183 pycore_create_interpreter+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66ad13 pyinit_config+0x6f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672633 pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          67270b Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a46f7 pymain_init+0xff (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a47c7 pymain_main+0xf (dora-stable-aarch64.refleak/build/python)\n\t          574f9b _PyUnicode_InitStaticStrings+0xd7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58d83b init_global_interned_strings+0x77 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58da73 _PyUnicode_InitGlobalObjects+0x5b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66a44b pycore_init_global_objects+0x23 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66aa77 pycore_interp_init+0x2b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66ad53 pyinit_config+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672633 pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          67270b Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a46f7 pymain_init+0xff (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a47c7 pymain_main+0xf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a485b Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41f2f7 main+0xb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff9931625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff9931633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41f1ef _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 1787385 1359244.241183:     229837 cycles:Pu: \n\t          64350c _Py_hashtable_get_entry_generic+0x4c (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          643957 _Py_hashtable_get+0xf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          55b19b intern_common+0x11b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58df47 _PyUnicode_InternMortal+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e003 PyUnicode_InternFromString+0x1f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4b24df descr_new+0x43 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4b366f PyDescr_NewGetSet+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          536853 type_add_getset+0x37 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5369f7 type_ready_fill_dict+0x37 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          543cfb type_ready+0x93 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          543f87 init_static_type+0x1a7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          54408b _PyStaticType_InitBuiltin+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          502e57 _PyTypes_InitTypes+0xa7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66a4b3 pycore_init_types+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66ab57 pycore_interp_init+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66ad53 pyinit_config+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672633 pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          67270b Py_InitializeFromConfig+0x97 (/home/bu

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Stable Refleaks 3.13 (tier-3) has failed when building commite2d13b4.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1662/builds/40) and take a look at the build logs.
  4. Check if the failure is related to this commit (e2d13b4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1662/builds/40

Failed tests:

  • test.test_multiprocessing_forkserver.test_processes
  • test.test_multiprocessing_spawn.test_processes
  • test_os

Failed subtests:

  • test_timerfd_ns_poll - test.test_os.TimerfdTests.test_timerfd_ns_poll

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_os.py", line4348, intest_timerfd_ns_pollself.check_timerfd_poll(True)~~~~~~~~~~~~~~~~~~~~~~~^^^^^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_os.py", line4333, incheck_timerfd_pollself.assertEqual(self.read_count_signaled(fd),1)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:2 != 1Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line2232, intest_timeoutself.assertEqual(len(results),self.barrier.parties)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:0 != 5Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/multiprocessing/resource_tracker.py", line279, inmain    cache[rtype].remove(name)~~~~~~~~~~~~~~~~~~~^^^^^^KeyError:'/psm_60771056'kTraceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line2252, intest_default_timeoutself.assertEqual(len(results), barrier.parties)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:0 != 5

seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…time() (pythonGH-131568)In particularly, fix regression in detecting stray % at the end of theformat string.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@serhiy-storchaka@bedevere-bot@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp