NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-131507: Add support for syntax highlighting in PyREPL#131562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ambv wants to merge3 commits intopython:mainfromambv:pyrepl-syntax-highlighting

Closed

gh-131507: Add support for syntax highlighting in PyREPL#131562

ambv wants to merge3 commits intopython:mainfromambv:pyrepl-syntax-highlighting

Conversation

Copy link

Contributor

ambv commentedMar 21, 2025•
edited by bedevere-appbot
Loading

Issue:Syntax highlighting in PyREPL #131507

pythongh-131507: Add support for syntax highlighting in PyREPL

35f01ca

ambv requested review frompablogsal andlysnikolaou ascode owners

March 21, 2025 18:00

bedevere-appbot added the awaiting core review label

Mar 21, 2025

bedevere-appbot mentioned this pull request

Mar 21, 2025

Syntax highlighting in PyREPL#131507

Closed

Add Blurb

ff14653

ambv mentioned this pull request

Mar 21, 2025

Add support for syntax highlighting in PyREPLambv/cpython#89

Closed

Wulian233 reviewed

Mar 22, 2025

View reviewed changes

Lib/_pyrepl/utils.py

		@@ -2,12 +2,56 @@
		import unicodedata
		import functools

		from idlelib import colorizer

Copy link

Contributor

Wulian233Mar 22, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fromidlelibimportcolorizer

On Windows, if you do not choose to install Tcl/Tk, IDLE will not be available

Seehttps://github.com/python/cpython/blob/main/Tools%2Fmsi%2Ftcltk%2Ftcltk.wixproj

Lib/_pyrepl/utils.py

		@@ -2,12 +2,56 @@
		import unicodedata
		import functools

		from idlelib import colorizer
		from typing import cast, Iterator, Literal, Match, NamedTuple, Pattern, Self

Copy link

Contributor

Wulian233Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Here are some deprecated aliases. Although there are no issues at present, it would be better to switch tocollection.abc

https://docs.python.org/3.14/library/typing.html#typing.Iterator

Viicos reviewed

Mar 22, 2025

View reviewed changes

Lib/_pyrepl/utils.py

Comment on lines +20 to +27

		type ColorTag = (
		Literal["KEYWORD"]
		\| Literal["BUILTIN"]
		\| Literal["COMMENT"]
		\| Literal["STRING"]
		\| Literal["DEFINITION"]
		\| Literal["SYNC"]
		)

Copy link

Contributor

ViicosMar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	typeColorTag= (
	Literal["KEYWORD"]
	\|Literal["BUILTIN"]
	\|Literal["COMMENT"]
	\|Literal["STRING"]
	\|Literal["DEFINITION"]
	\|Literal["SYNC"]
	)
	typeColorTag=Literal["KEYWORD","BUILTIN","COMMENT","STRING","DEFINITION","SYNC"]

Fix irrelevant Windows tests

75cd06d

ambv force-pushed thepyrepl-syntax-highlighting branch fromf4bd10f to75cd06dCompare

March 22, 2025 12:36

tomasr8 mentioned this pull request

Apr 12, 2025

gh-131952: Add color to thejson CLI#132126

Merged

Copy link

Member

tomasr8 commentedApr 19, 2025

Here's what it looks like with the default Ubuntu dark/light themes:

The contrast of the blue color seems a bit too low for the dark theme (I had the same issue in#132126). Maybe the 'intense' variant might look better?