Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-131535: Fix stale example inhtml.parser docs, make examples doctests#131551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

brianschubert
Copy link
Contributor

@brianschubertbrianschubert commentedMar 21, 2025
edited
Loading

Fixes#131535

Back in Python 3.5, the default forconvert_charrefs was changed fromFalse toTrue. One of the docs examples still assumes the old default ofFalse. This PR updates the example to reflect the current behavior.

Also migrates the examples to doctests to help catch any further discrepancies. Slightly tweaks two examples to avoid relying on trailing whitespace, which isn't visible in the output and makes doctests tricky.


📚 Documentation preview 📚:https://cpython-previews--131551.org.readthedocs.build/

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 7, 2025
@serhiy-storchakaserhiy-storchakaenabled auto-merge (squash)May 7, 2025 09:23
@serhiy-storchakaserhiy-storchaka merged commitee76e36 intopython:mainMay 7, 2025
24 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMay 7, 2025
@miss-islington-app
Copy link

Thanks@brianschubert for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry@brianschubert and@serhiy-storchaka, I had trouble checking out the3.14 backport branch.
Please retry by removing and re-adding the "needs backport to 3.14" label.
Alternatively, you can backport usingcherry_picker on the command line.

cherry_picker ee76e36d76a0e6916c0afc41228b043ab5174685 3.14

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 7, 2025
… doctests (pythonGH-131551)(cherry picked from commitee76e36)Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@bedevere-app
Copy link

GH-133587 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 7, 2025
brianschubert added a commit to brianschubert/cpython that referenced this pull requestMay 7, 2025
…xamples doctests (pythonGH-131551)(cherry picked from commitee76e36)Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@bedevere-app
Copy link

GH-133589 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 7, 2025
serhiy-storchaka pushed a commit that referenced this pull requestMay 7, 2025
…s doctests (GH-131551) (GH-133587)(cherry picked from commitee76e36)Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull requestMay 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

html.parser produces different output than documented
2 participants
@brianschubert@serhiy-storchaka

[8]ページ先頭

©2009-2025 Movatter.jp