Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-131524: Update platform CLI to use argparse#131542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 17 commits intopython:mainfromHarry-Lees:131524-patch-1
May 3, 2025

Conversation

Harry-Lees
Copy link
Contributor

@Harry-LeesHarry-Lees commentedMar 21, 2025•
edited
Loading

Closes:#131524
Related To:#131178

This PR updates the platform CLI to use argparse which adds--help flags and a usage section which was previously unavailable.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

And don't forget about a NEWS entry :)

@sobolevnsobolevn requested a review fromhugovkMarch 21, 2025 17:43
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We now have help which shows the arguments:

❯./python.exe -m platform -husage: python.exe -m platform [-h] [--terse] [--nonaliased] [{nonaliased,terse} ...]positional arguments:  {nonaliased,terse}options:  -h, --help          show this help message and exit  --terse  --nonaliased

But doesn't say what they do. Please can you add short descriptions?

Harry-Lees reacted with thumbs up emoji
Harry-Leesand others added4 commitsMarch 21, 2025 22:41
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Harry-Lees
Copy link
ContributorAuthor

But doesn't say what they do. Please can you add short descriptions?

The help message now gives a short description of each flag

usage: python.exe -m platform [-h] [--terse] [--nonaliased] [{nonaliased,terse} ...]positional arguments:  {nonaliased,terse}options:  -h, --help          show this help message and exit  --terse             return only the absolute minimum information needed to identify the platform  --nonaliased        disable system/ OS name aliasing. If aliasing is enabled, some platforms will report system names which differ from their common names, e.g. SunOS will be reported                      as Solaris

@Harry-LeesHarry-Lees requested a review fromhugovkMarch 21, 2025 23:11
Harry-Leesand others added5 commitsMarch 23, 2025 12:42
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@donBarbos
Copy link
Contributor

Maybe it's worth adding aCommand-line Usage section to theplatform documentation?

@hugovk
Copy link
Member

Maybe it's worth adding aCommand-line Usage section to theplatform documentation?

This can be a followup PR.

donBarbos reacted with thumbs up emoji

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@hugovk
Copy link
Member

@donBarbos GitHub says you requested changes, is there anything outstanding on this PR?

Copy link
Contributor

@donBarbosdonBarbos left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sorry, I thought I was only leaving comments

hugovk reacted with thumbs up emoji
@hugovkhugovkenabled auto-merge (squash)May 3, 2025 08:55
@hugovkhugovk merged commit77c391a intopython:mainMay 3, 2025
43 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sobolevnsobolevnsobolevn left review comments

@picnixzpicnixzpicnixz left review comments

@hugovkhugovkhugovk approved these changes

@donBarbosdonBarbosdonBarbos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improveplatform CLI
5 participants
@Harry-Lees@donBarbos@hugovk@sobolevn@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp