Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-130415: Optimize constant comparison in JIT builds#131489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brandtbucher merged 11 commits intopython:mainfromsavannahostrowski:pop_2
Mar 21, 2025

Conversation

savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commentedMar 20, 2025•
edited by bedevere-appbot
Loading

@savannahostrowskisavannahostrowski changed the titleGH-130415: Optimize constant comparisonGH-130415: Optimize constant comparison in JIT buildsMar 20, 2025
Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, this new instruction opens a lot of doors for us in the optimizer! A few things I noticed:

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@brandtbucher
Copy link
Member

JIT test failure looks unrelated, and due toGH-131488.

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a couple more things. Also, can you merge inmain? I think JIT CI should be fixed.

@brandtbucher
Copy link
Member

Tail-calling failure is unrelated, and showing up on other PRs too.

@brandtbucherbrandtbucher merged commitb92ee14 intopython:mainMar 21, 2025
66 of 68 checks passed
@brandtbucher
Copy link
Member

So next steps would be doing the same thing for the otherCOMPARE_OP specializations (COMPARE_OP_FLOAT andCOMPARE_OP_STR). Also for a bunch of BINARY_OP specializations like_BINARY_OP_ADD_INT, etc. (these are easier, since many of them already evaluate the constant... we just need to check to see if it's immortal).

Is this something you'd be interested in doing?

savannahostrowski reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-SpinnerFidget-Spinner is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@savannahostrowski@brandtbucher
[8]ページ先頭
©2009-2025 Movatter.jp