Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127833: lexical analysis: Improve section on Names#131474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 5 commits intopython:mainfromencukou:lex-analysis-names
May 21, 2025

Conversation

encukou
Copy link
Member

@encukouencukou commentedMar 19, 2025•
edited by github-actionsbot
Loading

Use consistent terminology: "names" are "identifiers", "keywords", and "soft keywords".
Start with the simple case (ASCII), then get more and more technical.
Define NAME in the formal lexical grammar.
Exclude keywords in theidentifier definition.

📚 Documentation preview 📚:https://cpython-previews--131474.org.readthedocs.build/

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@encukouencukou added the needs backport to 3.14bugs and security fixes labelMay 7, 2025
@terryjreedy
Copy link
Member

I like the re-arrangement and separation of identifier and keyword.

encukou reacted with heart emoji

@encukou
Copy link
MemberAuthor

Thanks for the reviews!
I plan to merge on Wednesday if there are no objections.

@encukouencukou merged commitc7364f7 intopython:mainMay 21, 2025
41 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMay 21, 2025
@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@encukouencukou deleted the lex-analysis-names branchMay 21, 2025 14:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2025
…-131474)(cherry picked from commitc7364f7)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Blaise Pabon <blaise@gmail.com>
@bedevere-app
Copy link

GH-134423 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 21, 2025
@miss-islington-app
Copy link

Sorry@encukou, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.14" label.
Please backport backport usingcherry_picker on the command line.

cherry_picker c7364f79b2fb01c251e22115875a46a2ec134dcd 3.14

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

@encukouencukou

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@encukou@terryjreedy@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp