Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-131453: Add missing constants to winsound module#131454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 6 commits intopython:mainfromaisk:winsound-improve
Mar 20, 2025

Conversation

@aisk
Copy link
Contributor

@aiskaisk commentedMar 19, 2025•
edited
Loading

SND_ALIAS_ID has not been added towinsound in this PR because it requires passing thehmod parameter to thePlaySound function. Since we do not expose this parameter, it does not make sense to addSND_ALIAS_ID before we support thehmod parameter.

BOOL PlaySound(   LPCTSTR pszSound,   HMODULE hmod,   DWORD   fdwSound);

Other possible macrons are added.

📚 Documentation preview 📚:https://cpython-previews--131454.org.readthedocs.build/

@zooba
Copy link
Member

LGTM. Any other changes coming here, or is this ready to merge?

@aisk
Copy link
ContributorAuthor

All usable constants are added in this PR, so it's ready to merge.


..data::MB_ICONWARNING

Play the ``SystemExclamation`` sound.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think these could all use a..versionadded:: next

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, added!

@zooba
Copy link
Member

zooba commentedMar 20, 2025•
edited
Loading

FWIW, theversionadded:: next is a literal "next" now - it gets replaced with the actual version on release. But it doesn't really matter for changes that aren't going to be backported - it should still end up as 3.14.

Ref:https://discuss.python.org/t/versionadded-next/65280

zware and aisk reacted with thumbs up emoji

@zoobazooba merged commit00a9844 intopython:mainMar 20, 2025
42 checks passed
@aiskaisk deleted the winsound-improve branchMarch 21, 2025 01:57
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zwarezwarezware left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aisk@zooba@zware
[8]ページ先頭
©2009-2025 Movatter.jp