Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.9] gh-121284: Fix email address header folding with parsed encoded-word (GH-122754)#131412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ncoded-word (pythonGH-122754)Email generators using email.policy.default may convert an RFC 2047encoded-word to unencoded form during header refolding. In a structuredheader, this could allow 'specials' chars outside a quoted-string,leading to invalid address headers and enabling spoofing. This changeensures a parsed encoded-word that contains specials is kept as anencoded-word while the header is refolded.[Better fix from@bitdancer.]---------(cherry picked from commit295b53d)Co-authored-by: Mike Edmunds <medmunds@gmail.com>Co-authored-by: R David Murray <rdmurray@bitdance.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>
bitdancer approved these changesMar 18, 2025
9a31386 intopython:3.9 14 checks passed
Uh oh!
There was an error while loading.Please reload this page.
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestApr 9, 2025
…ncoded-word (pythonGH-122754) (pythonGH-131412)Email generators using email.policy.default may convert an RFC 2047encoded-word to unencoded form during header refolding. In a structuredheader, this could allow 'specials' chars outside a quoted-string,leading to invalid address headers and enabling spoofing. This changeensures a parsed encoded-word that contains specials is kept as anencoded-word while the header is refolded.[Better fix from@bitdancer.](cherry picked from commit295b53d)Co-authored-by: Mike Edmunds <medmunds@gmail.com>Co-authored-by: R David Murray <rdmurray@bitdance.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Email generators using email.policy.default may convert an RFC 2047 encoded-word to unencoded form during header refolding. In a structured header, this could allow 'specials' chars outside a quoted-string, leading to invalid address headers and enabling spoofing. This change ensures a parsed encoded-word that contains specials is kept as an encoded-word while the header is refolded.
[Better fix from@bitdancer.]
(cherry picked from commit295b53d)