Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-85702: Catch IsADirectoryError in zoneinfo#131333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Requesting@vstinner I did not cover PermissionsError as you were not a fan of the idea (and neither am I) and I also can't test on windows. So I presumed its best to just stick to the title of the issue :-) |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Anything else I should do@vstinner |
I enabled auto-merge on this PR. |
d22604a intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@StanFromIreland for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
(cherry picked from commitd22604a)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Victor Stinner <vstinner@python.org>
GH-136130 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.