Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-128520: pathlib ABCs: allow tests to be run externally#131315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adjust the tests for the `pathlib.types` module so that they can be runagainst the `pathlib-abc` PyPI package, which is a backport of the modulefor older Python versions.Specifically, we add a `.support.is_pypi` switch that is false in thestdlib and true in the pathlib-abc package. This controls which packagewe import, and whether or not we run tests against `PurePath` and `Path`.For compatibility with older Python versions, we stop using`zipfile.ZipFile.mkdir()` and `zipfile.ZipInfo._for_archive()`.
17 tasks
This is already covered in test_ntpath.py.
cf9d1a4 intopython:main 38 checks passed
Uh oh!
There was an error while loading.Please reload this page.
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…on#131315)Adjust the tests for the `pathlib.types` module so that they can be runagainst the `pathlib-abc` PyPI package, which is a backport of the modulefor older Python versions.Specifically, we add a `.support.is_pypi` switch that is false in thestdlib and true in the pathlib-abc package. This controls which packagewe import, and whether or not we run tests against `PurePath` and `Path`.For compatibility with older Python versions, we stop using`zipfile.ZipFile.mkdir()` and `zipfile.ZipInfo._for_archive()`.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Adjust the tests for the
pathlib.typesmodule so that they can be run against thepathlib-abcPyPI package, which is a backport of the module for older Python versions.Specifically, we add a
.support.is_pypiswitch that is false in the stdlib and true in the pathlib-abc package. This controls which package we import, and whether or not we run tests againstPurePathandPath.For compatibility with older Python versions, we stop using
zipfile.ZipFile.mkdir()andzipfile.ZipInfo._for_archive().