Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-131189: Fix "msvcrt" import warning on Linux when "_ctypes" is not available.#131201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
On Linux, compiling without "libffi" causes a"No module named 'msvcrt'" warning when launching PyREPL.
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I cannot recreate the same setup as you have, can you please share what happens with this change in place?
@sobolevn steps to reproduce on a fresh Ubuntu Server 24.04.2 setup:
Then:
shows:
Here's afull log. with changes in this PR, it shows the following with the same setup:
Here's afull log.
this warning is misleading, because
this warning is consistent with the warning
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, it is clear now! LGTM. However, I am not the module's maintainer, let's wait for them to make the final decision :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
f320c95
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@plashchynski for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…is not available. (pythonGH-131201)Fix "msvcrt" import warning on Linux when "_ctypes" is not available.On Linux, compiling without "libffi" causes a"No module named 'msvcrt'" warning when launching PyREPL.(cherry picked from commitf320c95)Co-authored-by: Dzmitry Plashchynski <plashchynski@gmail.com>
GH-136668 is a backport of this pull request to the3.14 branch. |
… is not available. (GH-131201) (GH-136668)Fix "msvcrt" import warning on Linux when "_ctypes" is not available.On Linux, compiling without "libffi" causes a"No module named 'msvcrt'" warning when launching PyREPL.(cherry picked from commitf320c95)Co-authored-by: Dzmitry Plashchynski <plashchynski@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
On Linux, compiling without "libffi" causes a misleading warning
"No module named 'msvcrt'" when launching PyREPL.