Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-131170: fix duplicated sections in frames.md file#131177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
In the frames.md file at InternalDocs, change the firstduplicated title to Specials, and remove unnecessary contentunder the Specials section.
ghost commentedMar 13, 2025 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
auvipy left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks good to me.
| @@ -0,0 +1,2 @@ | |||
| The duplication of titles in the frames.md file at InternalDocs has been | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No need for a NEWS entry as it's internal documentation and not exposed documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you. However, it would be a good idea to add this comment as anote in thedevguide, specifically in the quick reference atstep 8. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you mean, the fact that it's an internal-only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess it doesn't hurt to specify when a NEWS entry is really needed. Thanks for the feedback!
sobolevn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
e9d210b intopython:mainUh oh!
There was an error while loading.Please reload this page.
picnixz commentedMar 13, 2025
I was planning to merge it after eating something but you beat me to it! |
sobolevn commentedMar 13, 2025
In fact, I was eating while merging 🥘 |
…1177)fix duplicated sections in frames.md fileIn the frames.md file at InternalDocs, change the firstduplicated title to Specials, and remove unnecessary contentunder the Specials section.
…1177)fix duplicated sections in frames.md fileIn the frames.md file at InternalDocs, change the firstduplicated title to Specials, and remove unnecessary contentunder the Specials section.
Uh oh!
There was an error while loading.Please reload this page.
In the "frames.md" file at InternalDocs, I have changed the first duplicated title toSpecials and removed the unnecessary content under theSpecials section.
InternalDocs/frames.md#131170