Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-93096: Moverandom benchmark into pyperformance#131144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
donBarbos wants to merge2 commits intopython:mainfromdonBarbos:issue-93096-random

Conversation

donBarbos
Copy link
Contributor

@donBarbosdonBarbos commentedMar 12, 2025•
edited by bedevere-appbot
Loading

@donBarbos
Copy link
ContributorAuthor

cc@vstinner
:-)

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

cc@hugovk

@rhettinger
Copy link
Contributor

This isn't a performance test. It is used by module maintainers to view generated distributions to see if they match the expected distributions.

@donBarbos
Copy link
ContributorAuthor

I think it would be right to get rid of the--test flags in modules with cli.
This flag is not documented and is not displayed in the--help output.

Andit seems author of this flag is not against removing it

@rhettinger
Copy link
Contributor

I'm going to decline this. It isn't part of the public API so there is no user benefit to removing it. I do use this when maintaining the module so it does have some value. And the test code has nothing to do with pyperformance so this PR would be moving the code from where a mainainer can find it to a place where it clearly doesn't make sense.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

@tim-onetim-oneAwaiting requested review from tim-one

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@donBarbos@rhettinger@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp