Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
gh-93096: Moverandom benchmark into pyperformance#131144
gh-93096: Moverandom benchmark into pyperformance#131144donbarbos wants to merge 2 commits intopython:mainfrom
random benchmark into pyperformance#131144Conversation
donbarbos commentedMar 12, 2025
cc@vstinner |
Misc/NEWS.d/next/Library/2025-03-12-14-55-56.gh-issue-93096.HfBYPA.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
cc@hugovk
rhettinger commentedMar 12, 2025
This isn't a performance test. It is used by module maintainers to view generated distributions to see if they match the expected distributions. |
donbarbos commentedMar 12, 2025
I think it would be right to get rid of the Andit seems author of this flag is not against removing it |
rhettinger commentedMar 20, 2025
I'm going to decline this. It isn't part of the public API so there is no user benefit to removing it. I do use this when maintaining the module so it does have some value. And the test code has nothing to do with pyperformance so this PR would be moving the code from where a mainainer can find it to a place where it clearly doesn't make sense. |
Uh oh!
There was an error while loading.Please reload this page.
This PR couples withpython/pyperformance#386
Inspired by#94613