Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-93096: Load doctests intest_itertools#131133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromdonbarbos:issue-93096-load-doctest
Mar 12, 2025

Conversation

@donbarbos
Copy link
Contributor

@donbarbosdonbarbos commentedMar 12, 2025•
edited by bedevere-appbot
Loading

We have one doctest inModules/itertoolsmodule.c and none intest_itertolls.py so this is definitely a bug like issue#131069

@donbarbos
Copy link
ContributorAuthor

I foundtests.addTest(doctest.DocTestSuite patterns in unittests and only these two tests loaded incorrect modules (modules without doctests)
cc@vstinner

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@vstinner
Copy link
Member

I modified the doctest with the change below, ranmake clinic && make, and then./python -m test test_itertools -v. I confirm that test_itertools catchs the typo (fails).

diff --git a/Modules/itertoolsmodule.c b/Modules/itertoolsmodule.cindex 3e425ee5f92..092316cf255 100644--- a/Modules/itertoolsmodule.c+++ b/Modules/itertoolsmodule.c@@ -124,7 +124,7 @@ or when the input iterable is exhausted.     >>> for batch in batched('ABCDEFG', 3):     ...     print(batch)     ...-    ('A', 'B', 'C')+    ('Aa', 'B', 'C')     ('D', 'E', 'F')     ('G',)
donbarbos reacted with thumbs up emoji

@vstinnervstinner merged commit15a8412 intopython:mainMar 12, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks@donbarbos for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 12, 2025
(cherry picked from commit15a8412)Co-authored-by: donBarbos <donbarbos@proton.me>
@bedevere-app
Copy link

GH-131136 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMar 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 12, 2025
(cherry picked from commit15a8412)Co-authored-by: donBarbos <donbarbos@proton.me>
@bedevere-app
Copy link

GH-131137 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMar 12, 2025
vstinner pushed a commit that referenced this pull requestMar 12, 2025
gh-93096: Load doctests in `test_itertools` (GH-131133)(cherry picked from commit15a8412)Co-authored-by: donBarbos <donbarbos@proton.me>
vstinner pushed a commit that referenced this pull requestMar 12, 2025
gh-93096: Load doctests in `test_itertools` (GH-131133)(cherry picked from commit15a8412)Co-authored-by: donBarbos <donbarbos@proton.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@donbarbos@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp