Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-93096: Update and documentpickle CLI#131097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 17 commits intopython:mainfromdonBarbos:issue-93096-pickle-cli-docs
Mar 14, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbosdonBarbos commentedMar 11, 2025
edited
Loading

@donBarbos
Copy link
ContributorAuthor

donBarbos commentedMar 11, 2025
edited
Loading

cc@vstinner as author of idea

in issue#130160 we're making backports for3.12 and3.13 versions. since this is a similar PR I suggest to stick to the same strategy

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

cc@picnixz

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Last nit and LGTM.

@picnixzpicnixz changed the titlegh-93096: Add CLI docs forpicklegh-93096: Update and document CLIpickleMar 13, 2025
@picnixzpicnixz changed the titlegh-93096: Update and document CLIpicklegh-93096: Update and documentpickle CLIMar 13, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

I'll wait for Hugo's review and then we can probably merge it (just for a last checkup)

donBarbos reacted with thumbs up emoji

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Co-authored-by: Victor Stinner <vstinner@python.org>
donBarbosand others added2 commitsMarch 14, 2025 10:15
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

Do we need a NEWS file? This started out as docs only, but we're changing the code inpickle.py here. Although it's in code that was not documented before now, so maybe not needed?

@picnixz
Copy link
Member

We changed the code but it was already not documented. I don't think it's worth a What's New entry, but a small NEWS entry may be nice. We could make it under Library to mention that we now usepprint.pp instead ofpprint.pprint to render pickle files.

hugovk reacted with thumbs up emoji

@vstinner
Copy link
Member

Please don't replace pprint.pprint() with pprint.pp() in this PR but write a separated change for that.

@donBarbos
Copy link
ContributorAuthor

donBarbos commentedMar 14, 2025
edited
Loading

Ok, I reverted usingpprint instead ofpp

@hugovk
Copy link
Member

Thanks, remember to push :)

donBarbos reacted with laugh emoji

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@vstinnervstinner merged commitf9d0531 intopython:mainMar 14, 2025
39 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMar 14, 2025
@vstinner
Copy link
Member

Merged, thank you.

donBarbos reacted with thumbs up emoji

plashchynski pushed a commit to plashchynski/cpython that referenced this pull requestMar 17, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

@vstinnervstinnervstinner approved these changes

@hugovkhugovkhugovk approved these changes

@JacobCoffeeJacobCoffeeJacobCoffee approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@donBarbos@picnixz@hugovk@vstinner@JacobCoffee

[8]ページ先頭

©2009-2025 Movatter.jp