Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
[3.12] gh-130959: Reject whitespace in fractions, in pure Pythonfromisoformat() (GH-130962) (GH-131076)#131086
Merged
vstinner merged 1 commit intopython:3.12fromMar 11, 2025
Conversation
…n `fromisoformat()` (pythonGH-130962) (pythonGH-131076)pythongh-130959: Reject whitespace in fractions, in pure Python `fromisoformat()` (pythonGH-130962)Fix the pure Python implementation of `fromisoformat()` to reject anynon-digit characters, including whitespace, in the fractional partof time specification. This makes the behavior consistent with the Cimplementation, and prevents incorrect parsing of these fractions(e.g. `.400 ` would be misinterpreted as `.04`).Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com>(cherry picked from commit33494b4)(cherry picked from commit27fd328)Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Michał Górny <mgorny@gentoo.org>
8f26a79 intopython:3.12 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-130959: Reject whitespace in fractions, in pure Python
fromisoformat()(GH-130962)Fix the pure Python implementation of
fromisoformat()to reject anynon-digit characters, including whitespace, in the fractional part
of time specification. This makes the behavior consistent with the C
implementation, and prevents incorrect parsing of these fractions
(e.g.
.400would be misinterpreted as.04).Co-authored-by: Peter Biermazintensitydev@gmail.com
Co-authored-by: Paul Ganssle1377457+pganssle@users.noreply.github.com
(cherry picked from commit33494b4)
(cherry picked from commit27fd328)
Co-authored-by: Victor Stinnervstinner@python.org
Co-authored-by: Michał Górnymgorny@gentoo.org