Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-93096: Remove-t and-v flags frompickle cli#131068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 2 commits intopython:mainfromdonBarbos:issue-93096-pickle
Mar 11, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbosdonBarbos commentedMar 11, 2025•
edited by bedevere-appbot
Loading

  • added load doctest to unittest
  • we still can run doctests using:./python -m doctest Lib/pickle.py -v

@@ -700,7 +700,7 @@ def test_multiprocessing_exceptions(self):


def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite())
tests.addTest(doctest.DocTestSuite(pickle))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, this looks like a bugfix. It should be backported. Can you extract this change into a new PR? It's not directly related to CLI changes.

Copy link
ContributorAuthor

@donBarbosdonBarbosMar 11, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, sure, should i open new issue or can i send PR for the current issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can reuse the same issue.

donBarbos reacted with thumbs up emoji
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would it be possible to document the current command line interface (CLI) in Doc/library/pickle.rst?https://docs.python.org/dev/library/pickle.html

@donBarbos
Copy link
ContributorAuthor

Would it be possible to document the current command line interface (CLI) in Doc/library/pickle.rst?https://docs.python.org/dev/library/pickle.html

I think it can be suggested in issue#130160

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@serhiy-storchaka: Are you ok with these changes?

@vstinner
Copy link
Member

I think it can be suggested in issue#130160

You can reuse#93096 or create a new issue.

donBarbos reacted with thumbs up emoji

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@vstinnervstinner merged commit425e0af intopython:mainMar 11, 2025
43 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…131068)* Remove `python -m pickle -t`* Revert adding doctest to unittests
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@donBarbos@vstinner@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp