Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-93096: Remove-t and-v flags frompickletools cli#131039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
-t and-v flags frompickletools cli-t and-v flags frompickletools cliI also made sure that unit tests call doctests, we add them here: cpython/Lib/test/test_pickletools.py Lines 517 to 519 in98fa4a4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
I confirm that these options are not documented at:https://docs.python.org/dev/library/pickletools.html#command-line-usage
@serhiy-storchaka: Are you ok with removing these undocumented pickletools CLI options?
He commented this changes here:#130973 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
3ddf983 intopython:mainUh oh!
There was an error while loading.Please reload this page.
…thon#131039)Remove `python -m pickletools -t`
Uh oh!
There was an error while loading.Please reload this page.
I'm also going to send a similar PR for the
picklemodule (for same flags)And I'm not sure if I should send a separate PR or I can add it here