Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-130664: specify how thousands separators are used with 0-padding#131030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Doc/library/string.rst Outdated
| (``'0'``) character enables sign-aware zero-padding for numeric types, | ||
| excluding:class:`complex`. This is equivalent to a *fill* character of | ||
| ``'0'`` with an *alignment* type of ``'='``. | ||
| ``'0'`` with an *alignment* type of ``'='``. If digit group separators of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm a bit surprised that "digit group separator" is mentioned here while we only mention it in the "grouping option" paragraph below. Maybe we should mention it at that place or mention here that this will be introduced below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since the different parts of the format are interconnected, there may be references to options described in details below.
But I think that we should unify wording and avoid repetition of what specifies the grouping option. "If thegrouping option for the integral part is used, a digit group separator is also inserted between leading zeros."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@serhiy-storchaka, I think that remark was addressed. Is there anything left?
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--131030.org.readthedocs.build/