Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130160: use.. program:: directive for documentinghttp.server CLI#131010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 5 commits intopython:mainfromdonBarbos:issue-130160-httpserver
Mar 15, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbosdonBarbos commentedMar 9, 2025•
edited
Loading

I wasn't sure if I should move the--cgi flag to this section as it is already deprecated and will be removed in3.15
It is currently located belowCGIHTTPRequestHandler class description

main branchPR branch
Screenshot from 2025-03-09 18-41-16Screenshot from 2025-03-09 18-55-30

📚 Documentation preview 📚:https://cpython-previews--131010.org.readthedocs.build/

@picnixz
Copy link
Member

Even if the flag is deprecated and planned for removal it's better to document as such. For the CLI rendering we can also just havepython -m http.server [OPTIONS] and list the options afterwards with some "The allowed options are listed below." introductory sentence.

donBarbos reacted with thumbs up emoji

@picnixzpicnixz added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsMar 9, 2025
@picnixz
Copy link
Member

picnixz commentedMar 9, 2025•
edited
Loading

Note that 3.13 is still a stable release and deprecated features are still legitimate to use

@donBarbos
Copy link
ContributorAuthor

Section was updated:

Screenshot from 2025-03-10 07-17-44

@picnixz
Copy link
Member

I'll review it at home

donBarbos reacted with thumbs up emoji

@picnixzpicnixz self-requested a reviewMarch 13, 2025 17:08
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@donBarbos
Copy link
ContributorAuthor

Thank you for review

hugovk reacted with rocket emoji

@hugovkhugovk merged commit7ae9c5d intopython:mainMar 15, 2025
24 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMar 15, 2025
@miss-islington-app
Copy link

Thanks@donBarbos for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 15, 2025
…erver` CLI (pythonGH-131010)(cherry picked from commit7ae9c5d)Co-authored-by: donBarbos <donbarbos@proton.me>
@miss-islington-app
Copy link

Sorry,@donBarbos and@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 7ae9c5dd25cccfc4e44fae6c6974ab9f32c5e985 3.12

@bedevere-app
Copy link

GH-131293 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMar 15, 2025
donBarbos added a commit to donBarbos/cpython that referenced this pull requestMar 15, 2025
@bedevere-app
Copy link

GH-131294 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMar 15, 2025
hugovk pushed a commit that referenced this pull requestMar 15, 2025
…server` CLI (GH-131010) (#131293)gh-130160: use `.. program::` directive for documenting `http.server` CLI (GH-131010)(cherry picked from commit7ae9c5d)Co-authored-by: donBarbos <donbarbos@proton.me>
mikec9 pushed a commit to mikec9/cpython that referenced this pull requestMar 17, 2025
…`http.server` CLI (pythonGH-131010) (python#131293)pythongh-130160: use `.. program::` directive for documenting `http.server` CLI (pythonGH-131010)(cherry picked from commit7ae9c5d)Co-authored-by: donBarbos <donbarbos@proton.me>
hugovk added a commit that referenced this pull requestMar 17, 2025
…server` CLI (GH-131010) (#131294)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
plashchynski pushed a commit to plashchynski/cpython that referenced this pull requestMar 17, 2025
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

@hugovkhugovkhugovk approved these changes

Assignees

@hugovkhugovk

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@donBarbos@picnixz@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp