Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
gh-130999: Avoid exiting the new REPL when there are non-string candidates for suggestions#131001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
b3055ab
Avoid exiting the new REPL when there are non-string candidates for s…
devdanzinf4773e9
📜🤖 Added by blurb_it.
blurb-it[bot]bd8115e
Merge branch 'main' into fix_non_string_candidates_exit_repl
devdanzin8008a58
Merge branch 'python:main' into fix_non_string_candidates_exit_repl
devdanzin5b395a0
Merge branch 'main' into fix_non_string_candidates_exit_repl
devdanzin1b73bba
Merge branch 'main' into fix_non_string_candidates_exit_repl
devdanzin3b9afd9
Make suggestions available even in the presence of non-string candida…
devdanzinc81143d
Guard against dir(obj) raising, add tests.
devdanzinFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Merge branch 'python:main' into fix_non_string_candidates_exit_repl
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit8008a5883421410f89a9c16037bd4b3e7455b210
There are no files selected for viewing
This merge commit was added into this branch cleanly.
There are no new changes to show, but you can stillview the diff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.