This PR adds a simple check that suggestion candidates are strings incalculate_suggestions(3.12)/_Py_CalculateSuggestions(main), avoiding an abort in debug builds from code like below:

importrunpyrunpy._run_module_code("blech", {0:"","bluch":""},"")

The abort only happens in 3.12, because the code in main checks for non-string candidates in_suggestions__generate_suggestions_impl. However, since the affected codeis still present in main, this PR is against that branch.

In main, the code above exits the new REPL, which will be reported as a new issue with associated PR.

Found usingfusil by@vstinner.

Issue:Failed assertion in_PyUnicode_Equal fromcalculate_suggestions with non-string candidate #129573

devdanzin added4 commits

March 8, 2025 22:13

Check that suggestion candidates in calculate_suggestions are strings.

85bcb1b

Add a test for the abort with non-string candidates in calculate_sug…

4586bba

…gestions.

Use a test that actually aborts on 3.12, still not testing the code c…

22ac8be

…hange in 3.14.

Merge branch 'main' into fix_nonstring_suggestions2

f47ecad

bedevere-appbot added the awaiting review label

Mar 9, 2025

bedevere-appbot mentioned this pull request

Mar 9, 2025

Failed assertion in_PyUnicode_Equal fromcalculate_suggestions with non-string candidate#129573

Open

picnixz added needs backport to 3.12

only security fixes

needs backport to 3.13bugs and security fixes labels

Mar 9, 2025

Copy link

Member

vstinner commentedMar 10, 2025

test_traceback is failing on the CI.

tomasr8 removed the needs backport to 3.12only security fixes label

Apr 10, 2025

Copy link

python-cla-botbot commentedApr 18, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

vstinner reviewed

Apr 18, 2025

View reviewed changes

Python/suggestions.cShow resolvedHide resolved

Copy link

Member

vstinner commentedApr 18, 2025

@devdanzin: Tests are failing on your PR, and you didn't sign the CLA. What's the status of this PR?

Copy link

ContributorAuthor

devdanzin commentedApr 18, 2025

I'm sorry, I've left this one fall behind. Would you like to take it over?

I have signed the CLA and even contributed some trivial code, I'll wait to see if it's a CLA bot issue or my CLA status changed to unverified somehow.

Merge branch 'main' into fix_nonstring_suggestions2

58a3697

vstinner reviewed

May 3, 2025

View reviewed changes

Lib/test/test_traceback.py Outdated

		def test_suggestions_do_not_trigger_with_non_string_candidates(self):
		def run_module_code():
		import runpy
		runpy._run_module_code("blech", {0: "", "bluch": ""}, "")