Please revert

Please revert.

More generally, can you upodatetest_translate_matching and include the examples ofhttps://man7.org/linux/man-pages/man7/glob.7.html so that we have a compliant implementation?

I'm not sure this is correct. From my understanding of manpages quoted in the issue, a class should be escaped only if it contains a literal path separator, not a range encompassing it. In latter case, we need to just exclude the separator.

[%-0]=> (?!/)[%-0][ab/]=> \[ab/\]

Edge case to be tested in bash andglob.glob: is a range beginning with separator ([%-/] or[/-0]) the first case or the second one? What about corner case of single element range[/-/]? I would say that all three should be escaped since they "contain an explicit/ character".

Also, does

A range containing an
explicit '/' character is syntactically incorrect. (POSIX requires that
syntactically incorrect patterns are left unchanged.)

mean that entire glob should be escaped, or just the part with the separator? I.e, does[ab][0/][xy] map to[ab]\[0/\][xy] or\[ab\]\[0/\]\[xy\]?

Relevant standard seems to be here:https://pubs.opengroup.org/onlinepubs/9699919799.2008edition/utilities/V3_chap02.html#tag_18_13_01

(Thus, "[]-]" matches just the two characters ']' and
'-', and "[--0]" matches the three characters '-', '.', and '0',
since '/' cannot be matched.)

This would indicate that a range which includes a '/' character as a non-literal would match that range but exclude the '/' character, at least with my interpretation.

I got that from the glob manpage.

2.13.3.1 looks to back my interpretation:

1. If path separator appears between brackets, be it a single character or next to a hyphen, escape entire bracket expression. For'\\' in seps case, be careful to check it is not an escape but actual'\\\\'.
2. Else, if any hyphened range spans a separator, add a negative lookahead. For simplicity, it can also be added for any bracket expression with a hyphen, or any bracket at all - result is the same, just simplifies regex in most cases.
3. All bracket expressions are analyzed separately, so path separator in one does not invalidate and escape all others.

@dmitya26 I don't have Python on hand, can you just quickly runglob.glob('a[/-b]c') on a following tree:

|-- abc`-- a[    `-- -b]c

If it returns[abc], then you are correct, if it returns the file in subdir then my interpretation seems to match existing implementation.

It returns '[]'.

edit: Oh wait I think I might've misread how the directories need to be structured.

├── a[
│   └── -b]c
└── abc

and

glob.glob('a[/-b]c')

would return

['a[/-b]c']

for me.

Wait so regarding the spec, do you think we should be disallowing only '/' characters, the system's path separator (os.path.sep), or all path separators mentioned like the ones in glob.translate?

Current implementation already extends the spec to all given separators, e.g.glob.translate('abc?', seps=['/', '\\']) maps to'(?s:abc[^/\\\\])\\Z'.