Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128041: Addterminate_workers andkill_workers methods to ProcessPoolExecutor#130849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 6 commits intopython:mainfromcsm10495:gh-128041-v2
Mar 5, 2025

Conversation

@csm10495
Copy link
Contributor

@csm10495csm10495 commentedMar 4, 2025•
edited by github-actionsbot
Loading

Provides a way to forcefully stop all the workers in the pool

Typically this would be used as a last effort to stop all workers if unable to shutdown / join in the expected way.

This is a newer version of#128043 that includes fixes for transient issues seen in CI.

📚 Documentation preview 📚:https://cpython-previews--130849.org.readthedocs.build/

153957 reacted with hooray emoji
…o ProcessPoolExecutorAdd some fixes to tests to make them no longer transient
@gpsheadgpshead added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMar 4, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gpshead for commitec7599c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130849%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMar 4, 2025
@csm10495
Copy link
ContributorAuthor

I've run

./python.exe -m test test.test_concurrent_futures.test_process_pool  -vvv --fail-env-changed

75 times in a row now without a failure.@colesbury mind checking again. Thanks for the feedback!

@csm10495csm10495 requested a review fromcolesburyMarch 4, 2025 18:59
@colesburycolesbury added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMar 4, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@colesbury for commit92a2d72 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130849%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMar 4, 2025
Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@csm10495, this looks good to me!

I rescheduled the buildbots and I'm also running some stress tests locally. So far, it looks good!

csm10495 and gpshead reacted with thumbs up emoji
@csm10495
Copy link
ContributorAuthor

I don't think those buildbot failures are related, but not 100% sure.

@gpsheadgpshead merged commitba05a4e intopython:mainMar 5, 2025
116 of 120 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…o ProcessPoolExecutor (pythonGH-130849)This adds two new methods to `multiprocessing`'s `ProcessPoolExecutor`:- **`terminate_workers()`**: forcefully terminates worker processes using `Process.terminate()`- **`kill_workers()`**: forcefully kills worker processes using `Process.kill()`These methods provide users with a direct way to stop worker processes without `shutdown()` or relying on implementation details, addressing situations where immediate termination is needed.Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Sam Gross@colesburyCommit-message-mostly-authored-by: Claude Sonnet 3.7 (because why not -greg)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes

@gpsheadgpsheadgpshead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csm10495@bedevere-bot@gpshead@colesbury
[8]ページ先頭
©2009-2025 Movatter.jp