Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-130827: Supporttyping.Self annotations insingledispatchmethod()#130829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
| # But, it shouldn't work on singledispatch() | ||
| with self.assertRaises(TypeError): | ||
| @test.register | ||
| def silly(self: typing.Self, arg: int | str) -> int | str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will'typing.Self' annotation work the same way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good question! It should, yeah.get_type_hints handles forward references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we add a test case for that, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Possibly, but as long asget_type_hints is working it's probably fine.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
@vstinner I'd like to get this fixed before 3.12 goes security-only next week. Would you mind reviewing? |
Wait why would we want to change this in 3.12 at all? Seems like a new feature to me. |
I agree, this is a new feature and should not be backported. |
Agreed with Jelle, this is a feature best left for a new release. Otherwise it's too hard to guard against in user code. |
Makes sense. I've updated the issue. |
Bump. I'd like to land this one before the beta freeze. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think special-casing theSelf annotation is the wrong approach. The self argument may be annotated withSelf, but it may also be annotated with e.g. a TypeVar or Annotated.
We should be ignoring annotations not on the basis of what the annotation is, but on the basis of what parameter they're on. I think the correct approach would be to figure out the name of the first non-self argument (i.e., the second argument for a method), then retrieve the annotation for that argument.
If I'm not mistaken, singledispatch also incorrectly (or at least unintuitively) handles cases where the annotation is on some later argument, but the first one is unannotated.
@registerdef f(x, random_arg: str = ...):A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Wouldn't that break if it's named something other than |
I mean the first argument that's not conceptually |
Uh oh!
There was an error while loading.Please reload this page.
singledispatchmethod.registerfails withtyping.Selfannotation #130827